[Freeipa-devel] [freeipa PR#236][comment] Build phase 7: cleanup

lslebodn freeipa-github-notification at redhat.com
Mon Nov 14 09:39:53 UTC 2016


  URL: https://github.com/freeipa/freeipa/pull/236
Title: #236: Build phase 7: cleanup

lslebodn commented:
"""
>Hi Lukas. Given there is no technical justification to have it I'm going to remove these. Simple is better than complex.
I am sorry I do not agree. The technical justification was explained in previous comments few time. The $(NULL) at the end of list makes patches much simpler and easier to read. The purpose of refactoring is make code simpler but also easier to **maintain/review**

"""

See the full comment at https://github.com/freeipa/freeipa/pull/236#issuecomment-260289586


More information about the Freeipa-devel mailing list