[Freeipa-devel] [freeipa PR#251][comment] Add rebuild rule for template files

[pspacek]

  URL: https://github.com/freeipa/freeipa/pull/251
Title: #251: Add rebuild rule for template files

pspacek commented:
"""
NACK:
- the variable is defined incorrectly, it should be in configure.ac (see Automake manual chapter [16 Rebuilding Makefiles](https://www.gnu.org/software/automake/manual/html_node/Rebuilding.html))
- file `install/ui/src/libs/loader.js` is missing in the list
- please reference build system refactoring ticket in the commit message
- even more importantly, there is a conceptual problem:
I'm not even sure that this is the right approach. CONFIG_STATUS_DEPEDENCIES is intended for re-building Makefiles and related infrastructure, not individual files generated from templates. With this patch it will re-run configure and config.status for the whole tree. The correct way to do this is to re-run config.status only for particular file. (config.status is the script which is doing actual variable substitution into templates.)

Fixing this might require moving these particular template substitutions from `AC_CONFIG_FILES` to Makefile.am in particular directories.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/251#issuecomment-261470338