[Freeipa-devel] [freeipa PR#259][opened] Minor fixes for IPAVersion class

tiran freeipa-github-notification at redhat.com
Mon Nov 21 09:03:51 UTC 2016


   URL: https://github.com/freeipa/freeipa/pull/259
Author: tiran
 Title: #259: Minor fixes for IPAVersion class
Action: opened

PR body:
"""
Py3: classes with __eq__ must provide __hash__ function or set __hash__
to None.
Comparison function like __eq__ must signal unsupported types by
returning NotImplemented. Python turns this in a proper TypeError.
Make the version member read-only and cache _bytes represention.

https://fedorahosted.org/freeipa/ticket/6473

Signed-off-by: Christian Heimes <cheimes at redhat.com>
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/259/head:pr259
git checkout pr259
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pr-259.patch
Type: text/x-diff
Size: 1781 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20161121/0c705c80/attachment.bin>


More information about the Freeipa-devel mailing list