[Freeipa-devel] [PATCH 190] expose `--secret` option in radiusproxy-* commands

Jan Cholasta jcholast at redhat.com
Wed Sep 7 14:25:14 UTC 2016


On 7.9.2016 16:13, Martin Babinsky wrote:
> On 09/07/2016 03:55 PM, Jan Cholasta wrote:
>> On 21.7.2016 10:50, Jan Cholasta wrote:
>>> On 21.7.2016 10:13, Martin Babinsky wrote:
>>>> On 07/20/2016 12:10 PM, Martin Babinsky wrote:
>>>>> On 07/19/2016 12:32 PM, Jan Cholasta wrote:
>>>>>> Hi,
>>>>>>
>>>>>> On 18.7.2016 13:51, Martin Babinsky wrote:
>>>>>>> https://fedorahosted.org/freeipa/ticket/6078
>>>>>>
>>>>>> I don't think we want the secret searchable. Add a 'no_search'
>>>>>> flag to
>>>>>> the param to fix that.
>>>>>>
>>>>>> Honza
>>>>>>
>>>>>
>>>>> 'no_search' flag breaks the API backwards compatibility, so I am
>>>>> sending
>>>>> another two patches which fix handling of deprecated options in the
>>>>> framework and deprecate `--secret` in radiusproxy-find command.
>>>>>
>>>>> I hope this solution is the best.
>>>>>
>>>>>
>>>>>
>>>> After discussion with Jan we realized that it is enough to hide the
>>>> '--secret' option from CLI, not deprecate it.
>>>>
>>>> Re-sending patch 190 and updated 193.1.
>>>
>>> Thanks, ACK.
>>>
>>> Pushed to master: 66da08445370f7024a6a529a6659714c33b7525e
>>>
>>>> Patch 192 will be send in
>>>> separate thread since the actual issue it fixes is orthogonal to this
>>>> one and requires a separate ticket.
>>>
>>> Right. ATM this only affects --srchostcat in hbacrule-find.
>>
>> Bump so that patch 192 is not forgotten.
>>
>
> Patch 192 was pushed as a fix to
> https://fedorahosted.org/freeipa/ticket/6190.

Okay.

-- 
Jan Cholasta




More information about the Freeipa-devel mailing list