[Freeipa-devel] [freeipa PR#617][comment] Allow renaming of sudo and HBAC rules

MartinBasti freeipa-github-notification at redhat.com
Fri Mar 24 13:23:03 UTC 2017


  URL: https://github.com/freeipa/freeipa/pull/617
Title: #617: Allow renaming of sudo and HBAC rules

MartinBasti commented:
"""
I like the `allow_rename` attribute, as it really explains what is happaning, Also I like the reworked check if primary key is in DN because original `self.obj.primary_key.name in entry_attrs` may return false positive results.

I'm afraid about one thing. This will basically break custom user plugins if they used `rdn_is_private_key`. Shall we do some backward compatibility magic?
"""

See the full comment at https://github.com/freeipa/freeipa/pull/617#issuecomment-289021080


More information about the Freeipa-devel mailing list