<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
On 06/29/2011 04:47 PM, Adam Young wrote:
<blockquote cite="mid:4E0B8F5B.9080701@redhat.com" type="cite">On
06/29/2011 12:52 PM, Endi Sukma Dewata wrote:
<br>
<blockquote type="cite">On 6/29/2011 11:30 AM, Adam Young wrote:
<br>
<blockquote type="cite">On 06/29/2011 10:34 AM, Adam Young
wrote:
<br>
<blockquote type="cite">On 06/29/2011 09:37 AM, Adam Young
wrote:
<br>
<blockquote type="cite">Better solution than the algorithm
in 256 for nested entities.
<br>
</blockquote>
</blockquote>
Changes for Hyphen and pkey names
<br>
</blockquote>
<br>
Some issues:
<br>
<br>
1. This statement will store undefined values into url_state:
<br>
<br>
url_state[key_name] = state[key_name];
<br>
<br>
We need to check whether the state[key_name] is undefined.
<br>
To test, open the UI, click the 'User Group' tab.
<br>
<br>
2. The following line should be located outside the for loop
that
<br>
iterates through the key names for that entity:
<br>
<br>
current_entity = current_entity.containing_entity;
<br>
<br>
This will cause a problem when there are more than 1 key
name.
<br>
<br>
3. Optionally, the get_key_names() could just return 'pkey'
instead
<br>
of the full '<entity name>-pkey'. The navigation code
can add the
<br>
prefix.
<br>
<br>
</blockquote>
<br>
<pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
Freeipa-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a></pre>
</blockquote>
ACKed in IRC by edewata and pushed to master with a minor tweak for
a JSL warning<br>
</body>
</html>