<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
On 07/06/2011 08:55 PM, Adam Young wrote:
<blockquote cite="mid:4E150407.7000705@redhat.com" type="cite">On
07/06/2011 08:12 PM, Endi Sukma Dewata wrote:
<br>
<blockquote type="cite">On 7/6/2011 4:32 PM, Adam Young wrote:
<br>
<blockquote type="cite">
<br>
</blockquote>
<br>
Some issues:
<br>
<br>
1. The check_required() is only called in blur events. It's not
called on Add/Update.
<br>
</blockquote>
<br>
Fixed. Looks like this works even for checkboxes.
<br>
<br>
<blockquote type="cite">
<br>
To test, open user's adder dialog, don't enter anything, just
click Add. The server will return an error (i.e.
check_required() not called).
<br>
<br>
Another test, edit an existing user, empty the first name, click
somewhere else, an error will appear because it loses focus.
Then click Update, the server will return an error (i.e.
check_required() not called).
<br>
<br>
2. In IPA.entity_select_widget the check_required() is only
called if the widget is editable.
<br>
<br>
To test, open IPA Server -> Configuration, set the Default
user group to empty, then click somewhere else. There's no
validation error.
<br>
</blockquote>
Fixed, but I don't think that there is currently a testable case
for this, as many things don't have required set.
<br>
<blockquote type="cite">
<br>
3. Also in IPA.entity_select_widget the check_required() is only
called from the text input's blur event, not from the drop down
list. This leads to strange behavior:
<br>
<br>
Open the hosts' adder dialog, click the drop down list, the
validation error will appear before the user has a chance to
select a value.
<br>
</blockquote>
Again fixed ,but not sure it is verifiable. host and service add
don't seem to have metadata for required.
<br>
<br>
<blockquote type="cite">
<br>
4. For consistency, the multivalued_text and textarea widgets
can be modified to call the create_error_link() to create the
error_link element.
<br>
</blockquote>
done
<br>
<blockquote type="cite">
<br>
5. There's a jslint warning.
<br>
</blockquote>
fixed.
<br>
<br>
<pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
Freeipa-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a></pre>
</blockquote>
Rebased<br>
</body>
</html>