<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> <html> <head> <meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type"> </head> <body bgcolor="#ffffff" text="#000000"> On 07/11/2011 11:54 AM, Endi Sukma Dewata wrote: <blockquote cite="mid:4E1B1CAA.3030409@redhat.com" type="cite">On 7/11/2011 10:50 AM, Endi Sukma Dewata wrote: <blockquote type="cite">A table has been added into sudo rule details page for managing sudo options. Ticket #1447 </blockquote> Patch attached. <pre wrap=""> <fieldset class="mimeAttachmentHeader"></fieldset> _______________________________________________ Freeipa-devel mailing list <a class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a> <a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a></pre> </blockquote> Tempted to ACK. Before I do, question: why did you make it a section as opposed to a widget? The only other place we have a custom section is for the permissions, where we are optionally showing a set of related widgets together, and we needed to reuse that logic between both the facet and the adder dialog. Neither case applies here. The only benefit I can see here is that it avoids the label. I suspect that the code should be written as a custom widget, not as a section. However, written this way is not such a major change from elsewhere that it is really going to confust people, so I won't NACK it on that alone. </body> </html>