<html>
<head>
<meta content="text/html; charset=iso-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 04/30/2013 05:24 PM, Petr Viktorin
wrote:<br>
</div>
<blockquote cite="mid:517FE22C.50607@redhat.com" type="cite">On
04/30/2013 02:32 PM, Tomas Babej wrote:
<br>
<blockquote type="cite">On 04/11/2013 09:57 PM, Rob Crittenden
wrote:
<br>
<blockquote type="cite">Tomas Babej wrote:
<br>
<blockquote type="cite">Hi,
<br>
<br>
In ipa-replica-manage commands, we enforce that hostnames we
work
<br>
with are resolvable. However, this caused errors while
deleting
<br>
or disconnecting a ipa / winsync replica, if that replica
was down
<br>
and authoritative server for itself.
<br>
<br>
<a class="moz-txt-link-freetext" href="https://fedorahosted.org/freeipa/ticket/3524">https://fedorahosted.org/freeipa/ticket/3524</a>
<br>
<br>
Tomas
<br>
</blockquote>
<br>
I'm not sure this is going to do the right thing either. A lot
of
<br>
these commands take the an argument as the remote master to
run things
<br>
on, so we'd really only be validating one of the names. Not
sure how
<br>
that helps us.
<br>
<br>
</blockquote>
Actually, the patch tried to adress that. I carefully reviewed
the
<br>
effort, now we should be consistent in validating all the names.
<br>
<br>
<blockquote type="cite">What if we honor the --force flag for
DNS lookup failures instead? Or,
<br>
since that could override it and do other things, a
--no-lookup flag
<br>
perhaps?
<br>
<br>
rob
<br>
</blockquote>
<br>
I added a --no-lookup flag for ipa-replica-manage that disables
host
<br>
existence check.
<br>
<br>
Sending both patches rebased.
<br>
<br>
Tomas
<br>
</blockquote>
<br>
</blockquote>
Thanks for the review,<br>
<blockquote cite="mid:517FE22C.50607@redhat.com" type="cite">The
nolookup argument is never passed to get_ruv() when it is called
by list_ruv, get_rid_by_host, clean_ruv, abort_clean_ruv. Some of
these don't take the argument but are called with it. Lint error:
<br>
install/tools/ipa-replica-manage:1188: [E1121, main] Too many
positional arguments for function call
<br>
<br>
</blockquote>
Fixed.<br>
<blockquote cite="mid:517FE22C.50607@redhat.com" type="cite">nolookup
is also not passed to list_clean_ruv(), re_initialize(),
force_sync(), show_DNA_ranges() etc.
<br>
<br>
</blockquote>
Fixed.<br>
<blockquote cite="mid:517FE22C.50607@redhat.com" type="cite">Git
complains about some extra whitespace:
<br>
Applying: Enforce host existence only where needed in
ipa-replica-manage
<br>
/home/pviktori/freeipa/.git/rebase-apply/patch:234: new blank line
at EOF.
<br>
+
<br>
warning: 1 line adds whitespace errors.
<br>
<br>
</blockquote>
Fixed<br>
<blockquote cite="mid:517FE22C.50607@redhat.com" type="cite">
<br>
<br>
</blockquote>
I added the ticket to the Minor Enhacements page:
<meta http-equiv="content-type" content="text/html;
charset=iso-8859-1">
<a href="http://freeipa.org/page/V3_Minor_Enhancements">http://freeipa.org/page/V3_Minor_Enhancements</a><br>
<br>
Tomas<br>
</body>
</html>