<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 10/15/2013 06:09 PM, Ana Krivokapic
wrote:<br>
</div>
<blockquote cite="mid:525D68BF.9050901@redhat.com" type="cite">
<pre wrap="">On 09/30/2013 10:02 AM, Petr Viktorin wrote:
</pre>
<blockquote type="cite">
<pre wrap="">On 09/27/2013 03:12 PM, Martin Kosek wrote:
</pre>
<blockquote type="cite">
<pre wrap="">On 09/27/2013 03:00 PM, Jan Cholasta wrote:
</pre>
<blockquote type="cite">
<pre wrap="">On 23.9.2013 19:41, Ana Krivokapic wrote:
</pre>
<blockquote type="cite">
<pre wrap="">On 09/19/2013 03:29 PM, Ana Krivokapic wrote:
</pre>
</blockquote>
</blockquote>
<pre wrap="">...
</pre>
<blockquote type="cite">
<pre wrap="">Patch 69:
I think the changes in the update file should be also done in the
right LDIF
files in install/share, though I don't know what is the recent
consensus on this.
Honza
</pre>
</blockquote>
<pre wrap="">
Last time I checked, we used to do the change both in LDIF and update
file. Just to avoid the LDIF become obsolete.
Martin
</pre>
</blockquote>
<pre wrap="">
Rob recently said his preference is to move everything from LDIF to updates,
and out of the the LDIF files:
<a class="moz-txt-link-freetext" href="http://www.redhat.com/archives/freeipa-devel/2013-September/msg00106.html">http://www.redhat.com/archives/freeipa-devel/2013-September/msg00106.html</a>
I would agree, having two places with the same information is redundant and
error-prone.
</pre>
</blockquote>
<pre wrap="">
Thanks Honza for the review.
I incorporated your suggestions in this updated patchset. I attached all the
patches for more convenient reviewing, but only patches 68 and 70 have changed.
I haven't done any changes in the LDIF files since the consensus seems to be not
to do that.
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Freeipa-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a></pre>
</blockquote>
<br>
Patch 70 needed a rebase, attaching the whole patchset again.<br>
<br>
<pre class="moz-signature" cols="80">--
Regards,
Ana Krivokapic
Associate Software Engineer
FreeIPA team
Red Hat Inc.</pre>
</body>
</html>