<html> <head> <meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> <div class="moz-cite-prefix">On 05/07/2014 03:47 PM, Petr Vobornik wrote: </div> <blockquote cite="mid:536A3985.20502@redhat.com" type="cite">krbpasswordexpiration conversion to number of second since epoch failed because now we get datetime object instead of string. <a class="moz-txt-link-freetext" href="https://fedorahosted.org/freeipa/ticket/4339">https://fedorahosted.org/freeipa/ticket/4339</a> <fieldset class="mimeAttachmentHeader"></fieldset> <pre wrap="">_______________________________________________ Freeipa-devel mailing list <a class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a> <a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a></pre> </blockquote> NACK, I don't think this is the right approach. This does not leverage the simplicity which the DateTime parameter refactoring provides. Instead of converting the datetime to the number of the seconds since epoch, and getting the current time represented by the number of seconds since the epoch (using time.time()), why not use datetime module and datetime.datetime.now() to get the current time? Then you could simplify this: + exp = time.mktime(expiration.timetuple()) + if exp <= time.time(): to this: + if expiration <= datetime.datetime.now() <pre class="moz-signature" cols="72">-- Tomas Babej Associate Software Engineer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej | freeipa.org </pre> </body> </html>