<html> <head> <meta content="text/html; charset=windows-1252" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> <div class="moz-cite-prefix">On 06/25/2014 10:48 AM, Petr Viktorin wrote: </div> <blockquote cite="mid:53AA8CCD.6000604@redhat.com" type="cite">On 06/19/2014 03:52 PM, Tomas Babej wrote: <blockquote type="cite"> On 06/19/2014 12:52 PM, Tomas Babej wrote: <blockquote type="cite">On 06/18/2014 10:52 AM, Petr Viktorin wrote: <blockquote type="cite">On 06/17/2014 02:15 PM, Tomas Babej wrote: <blockquote type="cite">On 06/17/2014 12:03 PM, Timo Aaltonen wrote: <blockquote type="cite">On 17.06.2014 11:16, Martin Kosek wrote: </blockquote> Attached is a new version of patch 226, and a new patch 228, which moves the paths from installers to the paths module. </blockquote> In patch 226, there's another "certificated" typo in remove_ca_cert_from_systemwide_ca_store <blockquote type="cite">I greped the repository, and I do not see many paths lurking around any more, there are only some in the error messages (as these can't be reliably replaced automatically, and will need some manual love). If you see any forgotten paths, which should be added to the module, let me know. </blockquote> </blockquote> </blockquote> </blockquote> Well, since you asked... install/tools/ipa-upgradeconfig:236: ipautil.run([paths.PKI_SETUP_PROXY, '-pki_instance_root=/var/lib' ipaserver/install/cainstance.py:1330: "-pki_instance_root=/var/lib", ipaserver/install/dsinstance.py:209:InstallLdifFile= /var/lib/dirsrv/boot.ldif ipaserver/install/dsinstance.py:210:inst_dir= /var/lib/dirsrv/scripts-$SERVERID ipaserver/install/ipa_backup.py:464: '--exclude=/var/lib/ipa/backup', ipatests/test_integration/tasks.py:451: host.run_command("find /var/lib/sss/db -name '*.ldb' | " install/tools/ipa-replica-conncheck:403: "/usr/sbin/ipa-replica-conncheck " + install/tools/ipa-replica-conncheck:414: print_info("/usr/sbin/ipa-replica-conncheck " + " ".join(remote_check_opts)) ipapython/ipautil.py:296: env["PATH"] = "/bin:/sbin:/usr/kerberos/bin:/usr/kerberos/sbin:/usr/bin:/usr/sbin" ipaserver/install/cainstance.py:88:ConfigFile = /usr/share/pki/ca/conf/database.ldif ipaserver/install/bindinstance.py:829: ipautil.run(['/usr/libexec/generate-rndc-key.sh']) </blockquote> /me will think twice about teasing nex time. This are paths requiring manual changes in one way or the other and as such cannot be handled by my tool. Let's not stall the patcheset on this. We can fix these (and surely there are other) as we go along. <blockquote cite="mid:53AA8CCD.6000604@redhat.com" type="cite"> I guess it'll be a while before we catch them all, but now it's at least clear where these paths should be, so anyone porting to another distro can send patches (or tickets) upstream. <blockquote type="cite"> <blockquote type="cite"> <blockquote type="cite">I see another duplicate: SSS_KRB5_INCLUDE_D = "/var/lib/sss/pubconf/krb5.include.d" SSSD_PUBCONF_KRB5_INCLUDE_D_DIR = "/var/lib/sss/pubconf/krb5.include.d/" </blockquote> </blockquote> </blockquote> Could you just pick one instead? Would ipa_backup.py break if it had a trailing slash here? </blockquote> <meta http-equiv="Content-Type" content="text/html; charset=windows-1252"> Yes. I verified it produces the same result with or without trailing slash, fixed. <blockquote cite="mid:53AA8CCD.6000604@redhat.com" type="cite">In ipa-client-install, if you set: NSSWITCH_CONF = paths.NSSWITCH_CONF then you should only use one of those later. (Preferably paths.*, to get rid of the redundant constants.) Perhaps this is for another patch that would clean up all the cases where these trivial module variables are used. </blockquote> I agree. Fixed this occurence. <blockquote cite="mid:53AA8CCD.6000604@redhat.com" type="cite"> <blockquote type="cite"> <blockquote type="cite">Fixed all mentioned issues. I also attached a patch 230, which removes the base Authconfig class. </blockquote> </blockquote> <blockquote type="cite">Attaching one additional patch, which removes unnecessary build warnings. </blockquote> 226, 230, 231 look good </blockquote> Attaching whole updated patchset. <pre class="moz-signature" cols="72">-- Tomas Babej Associate Software Engineer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej | freeipa.org </pre> </body> </html>