<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<div class="moz-cite-prefix">On 06/18/2014 09:54 AM, Petr Viktorin
wrote:<br>
</div>
<blockquote cite="mid:53A145CD.7000500@redhat.com" type="cite">On
06/17/2014 12:25 PM, Tomas Babej wrote:
<br>
<blockquote type="cite">
<br>
On 05/26/2014 06:20 PM, Petr Viktorin wrote:
<br>
<blockquote type="cite">On 05/20/2014 06:15 PM, Tomas Babej
wrote:
<br>
<blockquote type="cite">Hi,
<br>
<br>
the following set of patches fixes:
<br>
<br>
<a class="moz-txt-link-freetext" href="https://fedorahosted.org/freeipa/ticket/4274">https://fedorahosted.org/freeipa/ticket/4274</a>
<br>
<a class="moz-txt-link-freetext" href="https://fedorahosted.org/freeipa/ticket/4263">https://fedorahosted.org/freeipa/ticket/4263</a>
<br>
<a class="moz-txt-link-freetext" href="https://fedorahosted.org/freeipa/ticket/4324">https://fedorahosted.org/freeipa/ticket/4324</a>
<br>
<a class="moz-txt-link-freetext" href="https://fedorahosted.org/freeipa/ticket/4340">https://fedorahosted.org/freeipa/ticket/4340</a>
<br>
<a class="moz-txt-link-freetext" href="https://fedorahosted.org/freeipa/ticket/4341">https://fedorahosted.org/freeipa/ticket/4341</a>
<br>
<br>
and additional minor issues.
<br>
<br>
The improvemed CI test coverage for the sudorule plugin is
added as a
<br>
bonus.
<br>
</blockquote>
</blockquote>
</blockquote>
<br>
You've dropped most of the long commit messages and ticket URLs.
Why?
<br>
</blockquote>
<br>
Sorry about that.. fixed!<br>
<br>
<blockquote cite="mid:53A145CD.7000500@redhat.com" type="cite">
<br>
<br>
<blockquote type="cite">
<blockquote type="cite">0187: OK
<br>
</blockquote>
</blockquote>
<br>
<blockquote type="cite">
<blockquote type="cite">(Speaking of PEP8, if you could remove
the baseldap star import from
<br>
sudorule.py, it would be great...)
<br>
<br>
<br>
</blockquote>
This one did hurt, but the star disappeared.
<br>
</blockquote>
<br>
Thank you, much appreciated.
<br>
(Especially the fact that Int is no longer imported from baseldap)
<br>
<br>
<blockquote type="cite">
<blockquote type="cite">General thoughts:
<br>
<br>
Would it be possible to merge schema_compat.uldif and
<br>
install/updates/10-schema_compat.update into one file? Is the
uldif
<br>
special somehow? I guess this is a question for Rob.
<br>
It would be nice to add a link to some
schema-compat-entry-attribute
<br>
documentation to these files.
<br>
<br>
</blockquote>
I added Rob to cc. Rob, can you elaborate on this?
<br>
</blockquote>
<br>
<br>
<blockquote type="cite">
<blockquote type="cite">0188 - sudorule: Allow using hostmasks
for setting allowed hosts
<br>
</blockquote>
</blockquote>
<br>
If I run sudorule-add-host / sudorule-remove-host with a hostmask,
but not host/hostgroup, I get prompted for host and hostgroup. I
don't think that's the intended behavior.
<br>
</blockquote>
<meta http-equiv="Content-Type" content="text/html;
charset=ISO-8859-1">
<p>
This problem is beyond this patchset. Observe that same thing
happens with ipa group-add-member --external. I'm not sure if
there's a ticket for this though.</p>
<meta name="Description" content="Copy-Paste Buffer">
<meta name="Generator" content="Zim">
<br>
<br>
<blockquote cite="mid:53A145CD.7000500@redhat.com" type="cite">
<br>
0189: OK
<br>
0190: OK
<br>
0191: OK
<br>
0192: OK
<br>
<br>
<blockquote type="cite">
<blockquote type="cite">0193 sudorule: Make sure all the
relevant attributes are checked when
<br>
setting category to ALL
<br>
</blockquote>
</blockquote>
<br>
<blockquote type="cite">
<blockquote type="cite">You're missing the `_` for the
hostcategory error message.
<br>
Did you think about using something like _("%s cannot be set
to 'all'
<br>
while there are %s")?
<br>
<br>
</blockquote>
Fixed. Initially, I changed the message as you suggested, but
then I
<br>
realized, that this might pose a problem for translations that
do not
<br>
follow the word order in the sentence as it is defined in
English language.
<br>
</blockquote>
<br>
Right, sorry for the incorrect example. You can use named
substitutions for that:
<br>
_("can't %(action)s while %(state)s") % {'action': 'move',
'state': 'asleep'}
<br>
<br>
One more thing - the function is only called once, could you move
it to the for loop?
<br>
<br>
</blockquote>
<br>
Fixed!<br>
<br>
<blockquote cite="mid:53A145CD.7000500@redhat.com" type="cite">0194:
OK
<br>
0195: OK
<br>
0196-0198: OK
<br>
0199-0201: OK
<br>
<br>
0225:
<br>
Looks good. Could you also document the arguments & return
value in *_external_post_callback docstrings?
<br>
<br>
<br>
</blockquote>
<br>
I did. The updated patchset attached.<br>
<br>
<pre class="moz-signature" cols="72">--
Tomas Babej
Associate Software Engineer | Red Hat | Identity Management
RHCE | Brno Site | IRC: tbabej | freeipa.org </pre>
</body>
</html>