<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<br>
<div class="moz-cite-prefix">On 01/13/2015 01:36 PM, Martin Basti
wrote:<br>
</div>
<blockquote cite="mid:54B51165.3020808@redhat.com" type="cite">On
13/01/15 10:04, Martin Kosek wrote:
<br>
<blockquote type="cite">On 01/12/2015 06:43 PM, Martin Basti
wrote:
<br>
<blockquote type="cite">On 05/01/15 16:18, Martin Basti wrote:
<br>
<blockquote type="cite">On 17/12/14 15:15, Martin Basti wrote:
<br>
<blockquote type="cite">On 16/12/14 17:14, Martin Basti
wrote:
<br>
<blockquote type="cite">On 15/12/14 20:15, Martin Basti
wrote:
<br>
<blockquote type="cite">On 15/12/14 19:18, Martin Basti
wrote:
<br>
<blockquote type="cite"><a class="moz-txt-link-freetext" href="https://fedorahosted.org/freeipa/ticket/4750">https://fedorahosted.org/freeipa/ticket/4750</a>
<br>
<br>
Patches need rebase and minor pytest modification to
apply on master, I
<br>
will do that after review.
<br>
<br>
Patches for ipa-4-1 attached.
<br>
<br>
<br>
</blockquote>
I forgot to fix copy paste error.
<br>
<br>
Updated patches attached
<br>
<br>
</blockquote>
Removed unneeded nsrecord validation in 2 tests
<br>
<br>
updated patches attached
<br>
<br>
</blockquote>
Added:
<br>
<br>
* find forward zone with --forward-policy=none (no fwzone
exists)
<br>
* find forward zone with --forward-policy=only (no fwzone
exists)
<br>
* find forward zone with --forward-policy=first (no fwzone
exists)
<br>
* enable enabled zone
<br>
* disable disabled zone
<br>
<br>
Patches attached.
<br>
<br>
<br>
</blockquote>
Hi Scott, could you ack or nack the patchset, other test
tickets are waiting,
<br>
and we want to avoid huge rebases/merging
<br>
<br>
</blockquote>
From QA point of view, tests are OK. Can somebody do code
review please?
<br>
</blockquote>
Code looks OK, runs cleanly (except that I thought that
wait_for_dns is boolean
<br>
value and not an integer :-/)
<br>
<br>
So ACK from me. After you prepare a version for master branch,
we can push them.
<br>
<br>
Martin
<br>
</blockquote>
Rebased patches attached
<br>
<br>
<br>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Freeipa-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a></pre>
</blockquote>
<br>
Pushed to master: 92feba2223575856820c2b95beab88a5229b4f6e<br>
<br>
<pre class="moz-signature" cols="72">--
Tomas Babej
Associate Software Engineer | Red Hat | Identity Management
RHCE | Brno Site | IRC: tbabej | freeipa.org </pre>
</body>
</html>