<div dir="ltr">Good point. I personally was not aware of all that the API can do. Thanks Martin^2! Updated patch attached.<br><div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Feb 10, 2015 at 11:42 AM, Martin Basti <span dir="ltr"><<a href="mailto:mbasti@redhat.com" target="_blank">mbasti@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"><div><div class="h5">
<div>On 29/01/15 17:10, Gabe Alford wrote:<br>
</div>
</div></div><blockquote type="cite"><div><div class="h5">
<div dir="ltr">
<div>
<div>Hello,<br>
<br>
</div>
Fix for <a href="https://fedorahosted.org/freeipa/ticket/4872" target="_blank">https://fedorahosted.org/freeipa/ticket/4872</a><br>
<br>
</div>
Thanks,<br>
<br>
Gabe<br>
</div>
<br>
<fieldset></fieldset>
<br>
</div></div><pre>_______________________________________________
Freeipa-devel mailing list
<a href="mailto:Freeipa-devel@redhat.com" target="_blank">Freeipa-devel@redhat.com</a>
<a href="https://www.redhat.com/mailman/listinfo/freeipa-devel" target="_blank">https://www.redhat.com/mailman/listinfo/freeipa-devel</a></pre>
</blockquote>
Thank you for your patch.<br>
<br>
IMO, would be better to use flag, alwaysask for ipapermright,
instead of creating new callback:<br>
<br>
StrEnum(<br>
'ipapermright*',<br>
cli_name='right',<br>
deprecated_cli_aliases={'permissions'},<br>
label=_('Granted rights'),<br>
doc=_('Rights to grant '<br>
'(read, search, compare, write, add, delete,
all)'),<br>
values=(u'read', u'search', u'compare',<br>
u'write', u'add', u'delete', u'all'),<br>
+ alwaysask=True,<br>
),<br>
<br>
This change requires to generate new API.txt<br>
<br>
please run ./makeapi and increment API version in VERSION file.<br>
<br>
Thank you in advance :-)<br>
<br>
Martin^2<span class=""><font color="#888888"><br>
<pre cols="72">--
Martin Basti</pre>
</font></span></div>
</blockquote></div><br></div></div></div>