<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 25/02/15 17:23, thierry bordaz
wrote:<br>
</div>
<blockquote cite="mid:54EDF6F2.8080702@redhat.com" type="cite">
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<div class="moz-cite-prefix">On 02/25/2015 02:34 PM, Martin Basti
wrote:<br>
</div>
<blockquote cite="mid:54EDCF53.7050900@redhat.com" type="cite">Modifications:
<br>
* All plugins are migrated into new configuration style. <br>
* I left attribute uniqueness plugin disabled, cn=uid
uniqueness,cn=plugins,cn=config is checking the same attribute.
<br>
* POST_UPDATE plugin for uid removed, I moved it to update file.
Is it okay Alexander? I haven't found reason why we need to do
it in update plugin. <br>
<br>
Thierry, I touched configuration of plugins, which user
lifecycle requires, can you take look if I it does not break
anything? <br>
<br>
Patches attached. <br>
<br>
</blockquote>
<font face="Times New Roman, Times, serif">Hello Martin,<br>
<br>
The fix looks good. I have just one question regarding
install/updates/10-uniqueness.update.<br>
<br>
For example :<br>
</font>
<pre wrap=""># uid uniqueness scopes Active/Delete containers
dn: cn=attribute uniqueness,cn=plugins,cn=config
-remove:nsslapd-pluginarg1:'$SUFFIX'
-add:nsslapd-pluginarg1:'cn=accounts,$SUFFIX'
-add:nsslapd-pluginarg2:'cn=deleted users,cn=accounts,cn=provisioning,$SUFFIX'
+remove:uniqueness-subtrees:'$SUFFIX'
+add:uniqueness-subtrees:'cn=accounts,$SUFFIX'
+add:uniqueness-subtrees:'cn=deleted users,cn=accounts,cn=provisioning,$SUFFIX'
remove:nsslapd-pluginenabled:off
add:nsslapd-pluginenabled:on</pre>
<font face="Times New Roman, Times, serif">If we update the rpm
from a version where 'nsslapd-pluginarg1' was used.<br>
It will not remove it and we will have '</font><font face="Times
New Roman, Times, serif">nsslapd-pluginarg1' along with
'uniqueness-subtrees'.<br>
Should not we keep '</font><tt>remove:nsslapd-pluginarg1:'$SUFFIX''
?<br>
<br>
thanks<br>
thierry<br>
</tt> </blockquote>
Hello Thierry,<br>
<br>
in patch 0197 is pre-upgrade plugin, which migrate all uniqueness
plugins into new syntax (this happens before the update file is
applied). So no nsslapd-pluginarg* attrs will be there.<br>
<br>
and in patch 0198 I removed the cn=attribute uniquenes plugin, we
already have cn=uid uniqueness that do the same thing.<br>
<br>
Martin^2<br>
<br>
<pre class="moz-signature" cols="72">--
Martin Basti</pre>
</body>
</html>