<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 24/03/15 15:06, Aleš Mareček wrote:<br>
</div>
<blockquote
cite="mid:68938500.2798491.1427206014857.JavaMail.zimbra@redhat.com"
type="cite">
<pre wrap="">Greetings!
This is my very first patch, ticket#4746.
Have a nice day!
- alich -</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
Thank you for the patch. Just nitpicks:<br>
<br>
1)<br>
+ cleanup_commands = [<br>
+ ('dnszone_del', [zone6], {'continue': True}),<br>
+ ('dnszone_del', [zone6b], {'continue': True}),<br>
+ ]<br>
<br>
would be better do it in this way, continue option will to try
remove all zones:<br>
+ cleanup_commands = [<br>
+ ('dnszone_del', [zone6, zone6b], {'continue': True}),<br>
+ ]<br>
<br>
2)<br>
I'm fine with zone6b, but was there any reason to create zone6b,
instead of reusing zone 1 or 2 or 3?<br>
<br>
3)<br>
Please fix whitespace errors.<br>
$ git am
freeipa-alich-0001-ipatests-added-tests-for-SOA-record-Maintenance.patch<br>
Applying: ipatests - added tests for SOA record Maintenance<br>
/home/mbasti/work/freeipa-devel/.git/rebase-apply/patch:482:
trailing whitespace.<br>
<br>
/home/mbasti/work/freeipa-devel/.git/rebase-apply/patch:758: new
blank line at EOF.<br>
+<br>
warning: 2 lines add whitespace errors.<br>
<br>
4)<br>
I know the dns plugin tests are so far from PEP8, but try to keep
PEP8 in new code<br>
<br>
Otherwise test works as expected.<br>
<br>
Martin^2<br>
<pre class="moz-signature" cols="72">--
Martin Basti</pre>
</body>
</html>