<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 05/07/2015 01:38 PM, Petr Vobornik
wrote:<br>
</div>
<blockquote cite="mid:554B4E9F.1070806@redhat.com" type="cite">On
02/19/2015 03:51 PM, Petr Vobornik wrote:
<br>
<blockquote type="cite"><a class="moz-txt-link-freetext" href="https://fedorahosted.org/freeipa/ticket/4307">https://fedorahosted.org/freeipa/ticket/4307</a>
<br>
<br>
For ipa-4-1 apply:
<br>
- patch 800 (different thread)
<br>
- patches 801-806
<br>
<br>
For master apply:
<br>
- patch 800 (different thread)
<br>
- patch 807 (different thread)
<br>
- patch 801-master
<br>
- patches 802-806
<br>
<br>
Patch 801 allows to use ipalib rpc client in Web UI test suite.
<br>
Patches 802-805 are various ui_driver fixes to allow stuff in
patch 806.
<br>
<br>
== [PATCH] 806 webui-ci: otptoken tests ==
<br>
<br>
Basic otptoken Web UI CI coverage.
<br>
<br>
tests:
<br>
* crud for otptokens as admin
<br>
* crud for normal users
<br>
* checks fields of adder dialog for both token types and user
role
<br>
(admin/user)
<br>
* token actions as admin (enable, disable, delete)
<br>
* token actions as normal user (delete)
<br>
* login as normal user with hotp and totp token
<br>
* sync token hotp and totp token as normal user and then login
<br>
<br>
<a class="moz-txt-link-freetext" href="https://fedorahosted.org/freeipa/ticket/4307">https://fedorahosted.org/freeipa/ticket/4307</a>
<br>
<br>
== [PATCH] 805 webui-ci: allow custom names for disable/enable
actions ==
<br>
<br>
Not all disable and enable actions are called 'disable' and
'enable'.
<br>
<br>
== [PATCH] 804 webui-ci: allow to update pkey in post-add in
basic-crud
<br>
tests ==
<br>
<br>
== [PATCH] 803 webui-ci: add post_add_action ==
<br>
<br>
post add action allows to fill autogenerated values, e.g. a pkey
of new
<br>
otptoken.
<br>
<br>
This value can be then used in other subsequent test which would
depend
<br>
on it - like crud tests.
<br>
<br>
== [PATCH] 802 webui-ci: fix negative visibility check ==
<br>
<br>
Allow to define, that element doesn't have to be present on a
page for
<br>
negative visible checks.
<br>
<br>
E.g. if element is added only if it's displayed and is removed
otherwise.
<br>
<br>
== [PATCH] 801 webui-ci: support direct IPA API calls ==
<br>
<br>
Add IPA API support to ui_driver. It leverages new ipalib RPC
client's
<br>
forms based authentication. It then allows to call an IPA API
while
<br>
the machine is not an IPA client nor is kerberized.
<br>
<br>
api's environment values are taken from test configuration and
<br>
therefore duplication in ~/.ipa/default.conf is not required.
<br>
<br>
Since the machine doesn't have to be IPA client, it then also
doesn't
<br>
have nss database with IPA's CA certificate. Therefore on each
API
<br>
initialization a new NSS database is created with a CA
certificate
<br>
downloaded from IPA. This db is deleted in tearDown phase.
<br>
<br>
Usage:
<br>
<br>
1. as admin one can immediately call rpc commands, api will be
<br>
initialized upon first request and is available under self.api
<br>
(assuming self is ui_driver):
<br>
self.api.Command.user_del(USER_ID, **{'continue': True})
<br>
<br>
2. to reconnect as other user:
<br>
self.reconnect_api(USER_ID, USER_PW)
<br>
<br>
3. reconnect back as admin:
<br>
self.reconnect_api()
<br>
<br>
</blockquote>
<br>
Patch #803 needed rebase.
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
Hi, thanks for the patches.<br>
<br>
Please, fix pep8 complaints in 803, 805 and 806.<br>
Also, change the header in 806 to the shorter version, please.<br>
<br>
#<br>
# Copyright (C) 2015 FreeIPA Contributors see COPYING for license<br>
#<br>
<br>
Patches 801, 802 and 804 look good to me.<br>
The test cases in 806 look good to me as well.<br>
<br>
Milan<br>
</body>
</html>