<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 20/05/15 18:02, Rob Crittenden
wrote:<br>
</div>
<blockquote cite="mid:555CB00B.3080309@redhat.com" type="cite">Rob
Crittenden wrote: <br>
<blockquote type="cite">Rob Crittenden wrote: <br>
<blockquote type="cite">Add a plugin to manage service
delegations, like the one allowing the <br>
HTTP service to obtain an ldap service ticket on behalf of the
user. <br>
<br>
This does not include impersonation targets, so one cannot yet
limit by <br>
user what tickets can be obtained. <br>
<br>
There is also no referential integrity for the memberPrincipal
attribute <br>
since it is a string and not a DN. I don't see a way around
this that <br>
isn't either clunky or requires a 389-ds plugin, both of which
are <br>
overkill in this case IMHO. <br>
<br>
If you wonder why all the overrides it's because all of this
is stored <br>
in the same container, and membership-like functions are used
for a <br>
non-DN attribute (memberPrincipal). <br>
<br>
I used Alexander's patch in the ticket as a jumping off point.
<br>
</blockquote>
<br>
Removed a couple of hardcoded domain/realm elements in the
tests. <br>
</blockquote>
<br>
I must be getting rustly. Forgot to include ACIs. Added now. <br>
<br>
rob <br>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
Thank you.<br>
<br>
I haven't finished review yet, but I have few notes in case you will
modify the patch.<br>
<br>
Please fix following issues:<br>
<br>
1) Patch needs rebase, VERSION conflict<br>
<br>
2)<br>
+ pattern='^[a-zA-Z0-9_.][
a-zA-Z0-9_.-]{0,252}[a-zA-Z0-9_.-]?$',<br>
+ pattern_errmsg='may only include letters, numbers, _,
-, ., and a space inside',<br>
+ maxlength=255,<br>
<br>
If I count correctly, regexp allows only 254 characters, not 255,
and this regexp also allows the space at the end of the string.<br>
<br>
IMHO '^[a-zA-Z0-9_.]([ a-zA-Z0-9_.-]*[a-zA-Z0-9_.-])?$' would work.<br>
<br>
3)<br>
There are many PEP8 errors, can you fix some of them,?<br>
<br>
4)<br>
Please use<br>
except Exception as e: to be compatible with python 3<br>
<br>
5)<br>
For new files we stared using shorter license header.<br>
#<br>
# Copyright (C) 2015 FreeIPA Contributors see COPYING for license<br>
#<br>
<br>
<br>
<pre class="moz-signature" cols="72">--
Martin Basti</pre>
</body>
</html>