<div dir="ltr">Yup. You are right. It was a mistake. Updated patch attached. </div><div class="gmail_extra"> <div class="gmail_quote">On Tue, Sep 15, 2015 at 12:46 AM, Jan Cholasta <<a href="mailto:jcholast@redhat.com" target="_blank">jcholast@redhat.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 14.9.2015 14:58, Gabe Alford wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Sounds good to me. Updated patch attached. On Mon, Sep 14, 2015 at 1:34 AM, Petr Spacek <<a href="mailto:pspacek@redhat.com" target="_blank">pspacek@redhat.com</a> <mailto:<a href="mailto:pspacek@redhat.com" target="_blank">pspacek@redhat.com</a>>> wrote: On 14.9.2015 07:23, Jan Cholasta wrote: > IMO it does, because saying just "-1 is default" is not entirely correct and > "0 is default" would be confusing, as you pointed out. You might say "0 or -1 > is unlimited" if you think it's clearer. my +1 to "0 or -1 is unlimited" variant Petr^2 Spacek > On 10.9.2015 18:39, Gabe Alford wrote: >> Oops.. replied without the list. >> >> Reason I said -1 is because users might be confused if they enter `ipa >> config-mod --searchtimelimit=0`, and both `ipa user-show` and the webui >> show -1 instead of 0. I wonder if -1 makes more sense in that regard? >> Thoughts? Does "<= 0 is unlimited" make more sense? >> >> Thanks, >> >> Gabe </blockquote> The doc for ipasearchtimelimit and ipasearchrecordslimit says "-1 is unlimited", but both 0 and -1 is unlimited for them, and the doc for timelimit and sizelimit says "-1 or 0 is unlimited", but only 0 is unlimited for them. Looks like a mistake. -- Jan Cholasta </blockquote></div> </div>