<div dir="ltr"><div>Sorry. I had fixed another mistake and had not read your comment carefully. Updated patch attached.<br><br></div>Gabe<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Sep 16, 2015 at 12:23 AM, Jan Cholasta <span dir="ltr"><<a href="mailto:jcholast@redhat.com" target="_blank">jcholast@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 15.9.2015 14:42, Gabe Alford wrote:<br>
</span><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
Yup. You are right. It was a mistake. Updated patch attached.<br>
<br>
On Tue, Sep 15, 2015 at 12:46 AM, Jan Cholasta <<a href="mailto:jcholast@redhat.com" target="_blank">jcholast@redhat.com</a><br></span><span class="">
<mailto:<a href="mailto:jcholast@redhat.com" target="_blank">jcholast@redhat.com</a>>> wrote:<br>
<br>
On 14.9.2015 14:58, Gabe Alford wrote:<br>
<br>
Sounds good to me. Updated patch attached.<br>
<br>
On Mon, Sep 14, 2015 at 1:34 AM, Petr Spacek <<a href="mailto:pspacek@redhat.com" target="_blank">pspacek@redhat.com</a><br>
<mailto:<a href="mailto:pspacek@redhat.com" target="_blank">pspacek@redhat.com</a>><br></span><div><div class="h5">
<mailto:<a href="mailto:pspacek@redhat.com" target="_blank">pspacek@redhat.com</a> <mailto:<a href="mailto:pspacek@redhat.com" target="_blank">pspacek@redhat.com</a>>>> wrote:<br>
<br>
On 14.9.2015 07:23, Jan Cholasta wrote:<br>
> IMO it does, because saying just "-1 is default" is not<br>
entirely correct and<br>
> "0 is default" would be confusing, as you pointed out.<br>
You might say "0 or -1<br>
> is unlimited" if you think it's clearer.<br>
<br>
my +1 to "0 or -1 is unlimited" variant<br>
<br>
Petr^2 Spacek<br>
<br>
<br>
> On 10.9.2015 18:39, Gabe Alford wrote:<br>
>> Oops.. replied without the list.<br>
>><br>
>> Reason I said -1 is because users might be confused if they<br>
enter `ipa<br>
>> config-mod --searchtimelimit=0`, and both `ipa<br>
user-show` and<br>
the webui<br>
>> show -1 instead of 0. I wonder if -1 makes more sense<br>
in that<br>
regard?<br>
>> Thoughts? Does "<= 0 is unlimited" make more sense?<br>
>><br>
>> Thanks,<br>
>><br>
>> Gabe<br>
<br>
<br>
The doc for ipasearchtimelimit and ipasearchrecordslimit says "-1 is<br>
unlimited", but both 0 and -1 is unlimited for them, and the doc for<br>
timelimit and sizelimit says "-1 or 0 is unlimited", but only 0 is<br>
unlimited for them. Looks like a mistake.<br>
<br>
--<br>
Jan Cholasta<br>
<br>
<br>
</div></div></blockquote>
<br>
This hasn't changed since the previous patch and is still wrong, as -1 is not supported here:<br>
<br>
Int('timelimit?',<br>
label=_('Time Limit'),<br>
- doc=_('Time limit of search in seconds'),<br>
+ doc=_('Time limit of search in seconds (-1 or 0 is unlimited)'),<br>
flags=['no_display'],<br>
minvalue=0,<br>
autofill=False,<br>
),<br>
Int('sizelimit?',<br>
label=_('Size Limit'),<br>
- doc=_('Maximum number of entries returned'),<br>
+ doc=_('Maximum number of entries returned (-1 or 0 is unlimited)'),<br>
flags=['no_display'],<br>
minvalue=0,<br>
autofill=False,<span class="HOEnZb"><font color="#888888"><br>
<br>
-- <br>
Jan Cholasta<br>
</font></span></blockquote></div><br></div>