<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<br>
<br>
<div class="moz-cite-prefix">On 09/30/2015 12:19 PM, Oleg Fayans
wrote:<br>
</div>
<blockquote cite="mid:560BB737.2040609@redhat.com" type="cite">
<br>
<br>
On 09/30/2015 11:46 AM, Petr Spacek wrote:
<br>
<blockquote type="cite">On 29.9.2015 09:12, Oleg Fayans wrote:
<br>
<blockquote type="cite">+def prepare_reverse_zone(host, ip):
<br>
+ zone = get_reverse_zone_default(ip)
<br>
+ host.run_command(["ipa",
<br>
+ "dnszone-add",
<br>
+ zone,
<br>
+ "--name-from-ip=%s" % ip],
raiseonerr=False)
<br>
</blockquote>
<br>
There is probably no point in specifying --name-from-ip because
you did that
<br>
already by calling get_reverse_zone_default(ip).
<br>
</blockquote>
<br>
Agree. Fixed
<br>
<br>
<blockquote type="cite">
<br>
Anyway, I'm not sure that this
<br>
<blockquote type="cite">+ prepare_reverse_zone(master,
replica.ip)
<br>
</blockquote>
will not break if the reverse zone already exists (think about
case where two
<br>
or more replicas are in the same subnet).
<br>
</blockquote>
<br>
That's why I am using the raiseonerr=False here.
<br>
<br>
<blockquote type="cite">
<br>
I did not test the code, I simply do not have time for it right
now.
<br>
<br>
</blockquote>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
LGTM, I will test it soon, but it needs rebase for ipa-4-2 branch<br>
</body>
</html>