<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Sorry, we cannot push this patch because I realize that it breaks
API compatibility.<br>
<br>
The proper fix is add this code to find method (not tested)<br>
<br>
def get_options(self):<br>
for option in super(user_find, self).get_options():<br>
if option.name == "nsaccountlock":<br>
flags = set(option.flags)<br>
flags.remove("no_option")<br>
option = option.clone(flags=flags)<br>
yield option<br>
<br>
But I do not like too much this code, we plan to do some ipalib
refactoring in IPA 4.4, so we can do there bigger changes and solve
this issue in nicer way.<br>
If you don't mind, I would postpone this to IPA 4.4, instead of
hacking the framework<br>
<br>
Martin<br>
<br>
<div class="moz-cite-prefix">On 13.10.2015 19:12, Gabe Alford wrote:<br>
</div>
<blockquote
cite="mid:CAGLxfGwc7b387qZWML_VkygvbVyerCWhoH_EsmDuD=kT4gwuoQ@mail.gmail.com"
type="cite">
<div dir="ltr">Updated patch attached.<br>
<div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Tue, Oct 13, 2015 at 10:59 AM,
Martin Basti <span dir="ltr"><<a
moz-do-not-send="true" href="mailto:mbasti@redhat.com"
target="_blank"><a class="moz-txt-link-abbreviated" href="mailto:mbasti@redhat.com">mbasti@redhat.com</a></a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF"><span class=""> <br>
<br>
<div>On 13.10.2015 18:53, Gabe Alford wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div>
<div>Thanks Martin,<br>
<br>
</div>
What about adding no_create and no_update
flags? <br>
<br>
</div>
<div>Gabe<br>
</div>
</div>
</blockquote>
</span> Yes, that may work, also please increment
minor version of API and add ticket into commit
message (<a moz-do-not-send="true"
href="https://fedorahosted.org/freeipa/ticket/5366"
target="_blank">https://fedorahosted.org/freeipa/ticket/5366)</a><br>
<br>
Thanks.<span class="HOEnZb"><font color="#888888"><br>
Martin</font></span><span class=""><br>
<blockquote type="cite">
<div class="gmail_extra"><br>
<div class="gmail_quote">On Tue, Oct 13, 2015 at
9:54 AM, Martin Basti <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:mbasti@redhat.com"
target="_blank"><a class="moz-txt-link-abbreviated" href="mailto:mbasti@redhat.com">mbasti@redhat.com</a></a>></span>
wrote:<br>
<blockquote class="gmail_quote"
style="margin:0 0 0 .8ex;border-left:1px
#ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<div>
<div> <br>
<br>
<div>On 09.10.2015 19:17, Gabe Alford
wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div>
<div>
<div>Hello,<br>
<br>
</div>
This patch enables
nsaccountlock in user.py cli.
It is very handy to be able to
search and find users with
disabled/enabled accounts,
etc. That said, I couldn't
find why it was no_option in
the first place, so I am not
100% sure if it breaks
something or the reasoning
behind no_option.<br>
</div>
<div><br>
</div>
Thanks,<br>
<br>
</div>
Gabe<br>
</div>
<br>
<fieldset></fieldset>
<br>
</blockquote>
</div>
</div>
Hello,<br>
<br>
<a moz-do-not-send="true"
href="https://fedorahosted.org/freeipa/ticket/5366"
target="_blank">https://fedorahosted.org/freeipa/ticket/5366</a><br>
<br>
This patch allows to enable/disable user
via user-mod, and we do not want to do
this, so NACK for this patch.<br>
I'm not sure yet how to write it in
elegant way.<span><font color="#888888"><br>
<br>
Martin.<br>
</font></span></div>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</span></div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</blockquote>
<br>
</body>
</html>