<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<br>
<br>
<div class="moz-cite-prefix">On 20.10.2015 05:17, Gabe Alford wrote:<br>
</div>
<blockquote
cite="mid:CAGLxfGxVChUq7QYjsd=rMPk0RMMmOFe2jwN_F_HON6h=7j_M-w@mail.gmail.com"
type="cite">
<div dir="ltr">Bump for re-review.<br>
</div>
</blockquote>
<br>
Hello,<br>
<br>
thank your for your patch, the patch LGTM, but please use print() as
function to be python2/3 compatible<br>
<br>
Martin^2<br>
<blockquote
cite="mid:CAGLxfGxVChUq7QYjsd=rMPk0RMMmOFe2jwN_F_HON6h=7j_M-w@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Tue, Oct 13, 2015 at 7:15 AM,
Gabe Alford <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:redhatrises@gmail.com" target="_blank">redhatrises@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">
<div>
<div>
<div>No worries Petr. All a part of the review
process.<br>
<br>
</div>
I have attached an updated patch that prints only
a warning message.<br>
<br>
</div>
thanks,<br>
<br>
</div>
Gabe<br>
</div>
<div class="HOEnZb">
<div class="h5">
<div class="gmail_extra"><br>
<div class="gmail_quote">On Tue, Oct 13, 2015 at
12:39 AM, Petr Spacek <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:pspacek@redhat.com"
target="_blank"><a class="moz-txt-link-abbreviated" href="mailto:pspacek@redhat.com">pspacek@redhat.com</a></a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0
0 0 .8ex;border-left:1px #ccc
solid;padding-left:1ex">Hello Gabe,<br>
<br>
I would like to apologize for the confusion
regarding this patch and the<br>
repeated reworking.<br>
<br>
Unfortunately Honza's position is not
mentioned in the ticket so you could not<br>
know what to do, but Honza is our "installer
architect" so he has final say.<br>
<br>
Petr^2 Spacek<br>
<div>
<div><br>
On <a moz-do-not-send="true"
href="tel:13.10.2015" value="+13102015"
target="_blank">13.10.2015</a> 08:31,
Jan Cholasta wrote:<br>
> Hi,<br>
><br>
> I don't think this is the correct
approach. We are aiming to have idempotent<br>
> installers, which means that running
uninstall on a system without IPA<br>
> installed should be a no-op. This is
the current behavior, so your patch is<br>
> actually moving us back.<br>
><br>
> The proper fix would be to *remove*
the check from install (as opposed to<br>
> adding it to uninstall), but this
requires the install code to be
idempotent,<br>
> and we're not there yet.<br>
><br>
> I'm OK with making this a warning,
but don't make it a fatal error and/or<br>
> require --force.<br>
><br>
> Honza<br>
><br>
> On 12.10.2015 17:12, Gabe Alford
wrote:<br>
>> Thanks, Petr. Updated patch
attached.<br>
>><br>
>> Gabe<br>
>><br>
>> On Mon, Oct 12, 2015 at 12:47 AM,
Petr Spacek <<a moz-do-not-send="true"
href="mailto:pspacek@redhat.com"
target="_blank">pspacek@redhat.com</a><br>
>> <mailto:<a
moz-do-not-send="true"
href="mailto:pspacek@redhat.com"
target="_blank"><a class="moz-txt-link-abbreviated" href="mailto:pspacek@redhat.com">pspacek@redhat.com</a></a>>>
wrote:<br>
>><br>
>> Hello Gabe,<br>
>><br>
>> thank you for your patch!<br>
>><br>
>> Please note that there might
be a case where detection<br>
>> is_ipa_configured() is<br>
>> broken but the user still
needs to run the uninstall process to<br>
>> clean it up.<br>
>><br>
>> Could you amend the patch to
respect --force option? In that case the<br>
>> detection should be skipped.<br>
>><br>
>> Thank you for your time!<br>
>><br>
>> Petr^2 Spacek<br>
>><br>
>> On 9.10.2015 19:17, Gabe
Alford wrote:<br>
>> > diff --git
a/ipaserver/install/server/install.py<br>
>>
b/ipaserver/install/server/install.py<br>
>> > index<br>
>><br>
>>
13a59a0e6149dc22ded4a895db02516e9360e02b..ca93e7a6fd7276d9c0d82eb6f94575730759d858<br>
>><br>
>> 100644<br>
>> > ---
a/ipaserver/install/server/install.py<br>
>> > +++
b/ipaserver/install/server/install.py<br>
>> > @@ -954,6 +954,12 @@
def uninstall_check(installer):<br>
>> ><br>
>> >
installer._installation_cleanup = False<br>
>> ><br>
>> > + if not
is_ipa_configured():<br>
>> > + print("IPA
server is not configured on this
system.\n" +<br>
>> > + "If you
want to install the IPA server, please<br>
>> install " +<br>
>> > + "it
using 'ipa-server-install'.")<br>
>> > + sys.exit(1)<br>
>> > +<br>
>> > fstore =
sysrestore.FileStore(SYSRESTORE_DIR_PATH)<br>
>> > sstore =
sysrestore.StateFile(SYSRESTORE_DIR_PATH)<br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
<br>
</body>
</html>