<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<br>
<br>
<div class="moz-cite-prefix">On 22.10.2015 15:23, Martin Basti
wrote:<br>
</div>
<blockquote cite="mid:5628E35A.30308@redhat.com" type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
<br>
<div class="moz-cite-prefix">On 22.10.2015 14:13, Oleg Fayans
wrote:<br>
</div>
<blockquote cite="mid:5628D2CF.2000107@redhat.com" type="cite"> <br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
<br>
Hello,<br>
<br>
thank you for the patch.<br>
<br>
1)<br>
please remove the added empty lines, they are unrelated to this
ticket<br>
<br>
2)<br>
-def install_master(host, setup_dns=True, setup_kra=False):<br>
+def install_master(host, setup_dns=True, setup_kra=False,
domainlevel=1):<br>
<br>
I suggest to use default domainlevel=None, which will use the
default domain level (specified in build)<br>
<br>
3)<br>
+ domain_level = domainlevel(master)<br>
I do not think that this meets expectations.<br>
<br>
We have to test, both domain level 0 and 1 for IPA 4.3,
respectively new IPA must support all older domain levels, domain
level is independent on IPA version, only admin can raise it up.<br>
<br>
So you have to find out way how to pass the domain level for which
test will be running, we were talking about using config files,
but feel free to find something new and better<br>
<br>
4)<br>
Did you resolve the pytest fixtures which specifies which tests
can be run under which domain level?<br>
<br>
5)<br>
+ '--ip-address', client.ip,<br>
<br>
why this change to client install?<br>
<br>
Martin^2<br>
<br>
<br>
</blockquote>
6)<br>
************* Module ipatests.test_integration.tasks<br>
ipatests/test_integration/tasks.py:85:
[E1123(unexpected-keyword-arg), allow_sync_ptr] Unexpected keyword
argument 'raiseonerr' in function call)<br>
<br>
<br>
</body>
</html>