<html> <head> <meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> <div class="moz-cite-prefix">On 10/12/2015 01:17 PM, Ludwig Krispenz wrote: </div> <blockquote cite="mid:561B96CE.9060404@redhat.com" type="cite"> <meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type"> <div class="moz-cite-prefix">On 10/12/2015 12:44 PM, Martin Basti wrote: </div> <blockquote cite="mid:561B8F0B.4070907@redhat.com" type="cite"> <meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type"> <div class="moz-cite-prefix">On 23.07.2015 10:46, Ludwig Krispenz wrote: </div> <blockquote cite="mid:55B0A9F0.4010602@redhat.com" type="cite">The attached patch moves the cleaning of the RUV into the topology plugin. I encountered a problem when removing a replica, which disconnects the topology, but it was fixed with my WIP for #5072. I want to keep these issues separate, so please review and test the patch and let me know about issues found Ludwig <fieldset class="mimeAttachmentHeader"></fieldset> </blockquote> Is this patch still valid and pending review? </blockquote> it should be still valid, waiting for review, wanted to rebase after topology/promotion patches have been checked in and resend <fieldset class="mimeAttachmentHeader"></fieldset> </blockquote> Hello Ludwig, The patch looks good. I have few minor remarks: <ul> <li>Are the hostname in ruv always fqdn ? to retrieve the RUV element of a given host you use 'strstr'. If you have host vm-11 and vm-112, I wonder if it could pickup the wrong RUV element</li> <li>In ipa_topo_util_cleanruv_element you need a pblock_done/free (or destroy) </li> <li>In it fails to add the clearn-ruv task, you should log a message so that the admin knows what to do.</li> </ul> thanks thierry </body> </html>