<div dir="ltr">Fixed. Updated patch attached. </div><div class="gmail_extra"> <div class="gmail_quote">On Wed, Dec 9, 2015 at 2:37 AM, Martin Basti <<a href="mailto:mbasti@redhat.com" target="_blank">mbasti@redhat.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">NACK Patch contains syntax error, missing brace ipaserver/install/server/replicainstall.py:850: [E0001(syntax-error), ] invalid syntax) Martin<div class="HOEnZb"><div class="h5"> On 09.12.2015 07:08, Jan Cholasta wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> LGTM On 8.12.2015 17:04, Gabe Alford wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Updated patch attached. On Tue, Dec 8, 2015 at 8:27 AM, Martin Basti <<a href="mailto:mbasti@redhat.com" target="_blank">mbasti@redhat.com</a> <mailto:<a href="mailto:mbasti@redhat.com" target="_blank">mbasti@redhat.com</a>>> wrote: On 08.12.2015 16:26, Gabe Alford wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Just to confirm: if server is installed: Let's stop here and not do anything else if domain level 0: check if client installed and stop here Right? </blockquote> yes <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> On Tue, Dec 8, 2015 at 8:20 AM, Jan Cholasta <<a href="mailto:jcholast@redhat.com" target="_blank">jcholast@redhat.com</a> <mailto:<a href="mailto:jcholast@redhat.com" target="_blank">jcholast@redhat.com</a>>> wrote: On 8.12.2015 16:17, Martin Basti wrote: On 08.12.2015 16:14, Jan Cholasta wrote: On 8.12.2015 16:09, Martin Basti wrote: On 01.12.2015 14:57, Gabe Alford wrote: Sorry guys, I forgot to add a meaningful subject to this message. Ignore the previous thread start. ---------- Forwarded message ---------- From: *Gabe Alford* <<a href="mailto:redhatrises@gmail.com" target="_blank">redhatrises@gmail.com</a> <mailto:<a href="mailto:redhatrises@gmail.com" target="_blank">redhatrises@gmail.com</a>> <mailto:<a href="mailto:redhatrises@gmail.com" target="_blank">redhatrises@gmail.com</a> <mailto:<a href="mailto:redhatrises@gmail.com" target="_blank">redhatrises@gmail.com</a>>>> Date: Mon, Nov 30, 2015 at 7:31 PM Subject: [PATCH 0065] To: freeipa-devel <<a href="mailto:freeipa-devel@redhat.com" target="_blank">freeipa-devel@redhat.com</a> <mailto:<a href="mailto:freeipa-devel@redhat.com" target="_blank">freeipa-devel@redhat.com</a>> <mailto:<a href="mailto:freeipa-devel@redhat.com" target="_blank">freeipa-devel@redhat.com</a> <mailto:<a href="mailto:freeipa-devel@redhat.com" target="_blank">freeipa-devel@redhat.com</a>>>> Hello, Patch fix for the following tickets: <a href="https://fedorahosted.org/freeipa/ticket/5022" rel="noreferrer" target="_blank">https://fedorahosted.org/freeipa/ticket/5022</a> <a href="https://fedorahosted.org/freeipa/ticket/5320" rel="noreferrer" target="_blank">https://fedorahosted.org/freeipa/ticket/5320</a> Thanks, Gabe ACK NACK, you can't install a server over an already installed client, thus the original check is correct. Ahh domain level 0, right, but this check can be added before the client check. Yes. With domain level 1, this check should stay there IMO. Yes. It should say "IPA server is already configured" rather than "IPA replica is already configured", though. -- Jan Cholasta </blockquote> </blockquote> </blockquote> </div></div></blockquote></div> </div>