<html> <head> <meta content="text/html; charset=windows-1252" http-equiv="Content-Type"> </head> <body text="#000000" bgcolor="#FFFFFF"> <div class="moz-cite-prefix">On 12/09/2015 10:13 AM, Martin Basti wrote: </div> <blockquote cite="mid:5667F0A6.1090104@redhat.com" type="cite"> <meta content="text/html; charset=windows-1252" http-equiv="Content-Type"> <div class="moz-cite-prefix">On 09.12.2015 09:41, Lenka Doudova wrote: </div> <blockquote cite="mid:5667E942.7030305@redhat.com" type="cite">Hi, attaching fixed patches for master and ipa-4-2 branch. Also fixes test accordingly to <a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://fedorahosted.org/freeipa/ticket/5387">https://fedorahosted.org/freeipa/ticket/5387</a>. Lenka On 11/20/2015 12:13 PM, Martin Babinsky wrote: <blockquote type="cite">On 11/19/2015 10:34 AM, Petr Viktorin wrote: <blockquote type="cite">On 11/19/2015 09:30 AM, Lenka Doudova wrote: <blockquote type="cite">On 11/18/2015 04:51 PM, Martin Babinsky wrote: <blockquote type="cite">On 11/18/2015 02:16 PM, Lenka Doudova wrote: <blockquote type="cite">Hi, here's a patch that adds a few comments to stageuser tests in order to allow easier determining of a problem when tests fail. Lenka </blockquote> Hi Lenka, Firstly a technical detail: Python indexes lists from 0, so the comments in 'options_ok' do not correctly map to the test names anyway. I am also not sure if this patch is worth reviewing and pushing as it IMHO doesn't help in the identification of failed tests at all. This should be solved at more fundamental level. </blockquote> Ouch, good point, I didn't realize. Sorry. Anyway, the issue is that even if tests are run in verbose mode, you get output like this: ipatests/test_xmlrpc/test_stageuser_plugin.py::TestStagedUser::test_create_attr[stageduser27] PASSED ipatests/test_xmlrpc/test_stageuser_plugin.py::TestStagedUser::test_create_attr[stageduser28] PASSED ipatests/test_xmlrpc/test_stageuser_plugin.py::TestStagedUser::test_create_attr[stageduser29] PASSED ipatests/test_xmlrpc/test_stageuser_plugin.py::TestStagedUser::test_create_attr[stageduser210] PASSED ipatests/test_xmlrpc/test_stageuser_plugin.py::TestStagedUser::test_create_attr[stageduser211] PASSED ipatests/test_xmlrpc/test_stageuser_plugin.py::TestStagedUser::test_create_attr[stageduser212] PASSED If some test fails, you can't really tell which command was the one responsible for the fail. This should be solved by <a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://fedorahosted.org/freeipa/ticket/5449">https://fedorahosted.org/freeipa/ticket/5449</a>. Until that's done, though, the only way to find out which command failed is looking at the code and finding which parameters were put into the command, which was not much possible without better commenting the test case (as I realized last week when David Kupka asked me to help him find the reason for failed tests). Obviously I can rewrite the tests so there's 27 separate test cases, one for each parameter, instead of one method that 'unwraps' into 27 test cases, which would entirely eliminate the confusion. So far I don't know of a way to put 27 similar test cases in one method which would allow easy recognition of the test cases. I'll wait with fixing the patch until further discussion. </blockquote> Hello, Pytest wants you to be a bit more explicit about how to name the parameters. (It "hides" dicts by default, because large dicts would make the output even more confusing than the numbers.) Please try the attached patch. Docs are at <a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://pytest.org/latest/fixture.html#parametrizing-a-fixture">https://pytest.org/latest/fixture.html#parametrizing-a-fixture</a> </blockquote> This looks like a better approach IMHO, you can then see which attribute/value was being checked. I would very much favor more descriptive test/fixture names in the beginning. </blockquote> <fieldset class="mimeAttachmentHeader"></fieldset> </blockquote> Hello, we use usually bottom posting on freeipa-devel please try to keep reply in this way. Patch: I do not like the idea of separated lists, IMO it is hard to manage and is easy to create mistakes. How about this (untested, just from top of my head): <a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://fpaste.org/298994/65184014/"><a class="moz-txt-link-freetext" href="http://fpaste.org/298994/65184014/">http://fpaste.org/298994/65184014/</a></a> Martin </blockquote> Great idea, thanks. Fixed patches attached. Lenka </body> </html>