<html> <head> <meta content="text/html; charset=windows-1252" http-equiv="Content-Type"> </head> <body text="#000000" bgcolor="#FFFFFF"> <div class="moz-cite-prefix">On 24.02.2016 08:34, Milan Kubík wrote: </div> <blockquote cite="mid:56CD5D22.9000404@redhat.com" type="cite"> <meta content="text/html; charset=windows-1252" http-equiv="Content-Type"> <div class="moz-cite-prefix">On 02/18/2016 03:52 PM, Milan Kubík wrote: </div> <blockquote cite="mid:56C5DA92.4090805@redhat.com" type="cite"> <meta content="text/html; charset=windows-1252" http-equiv="Content-Type"> <div class="moz-cite-prefix">On 02/15/2016 04:59 PM, Milan Kubík wrote: </div> <blockquote cite="mid:56C1F5C6.2090708@redhat.com" type="cite">Patch attached. Applies on ipa-4-3 as well. <fieldset class="mimeAttachmentHeader"></fieldset> </blockquote> Updated version of patch fixes test_old_permission_plugin as well. <pre class="moz-signature" cols="72">-- Milan Kubik</pre> <fieldset class="mimeAttachmentHeader"></fieldset> </blockquote> Review bump. <pre class="moz-signature" cols="72">-- Milan Kubik</pre> <fieldset class="mimeAttachmentHeader"></fieldset> </blockquote> NACK [mbasti@dhcp129-96 freeipa-devel]$ git show -U0 | pep8 --diff ./ipatests/test_xmlrpc/test_old_permission_plugin.py:528:80: E501 line too long (95 > 79 characters) ./ipatests/test_xmlrpc/test_old_permission_plugin.py:586:1: E101 indentation contains mixed spaces and tabs ./ipatests/test_xmlrpc/test_old_permission_plugin.py:586:1: W191 indentation contains tabs ./ipatests/test_xmlrpc/test_old_permission_plugin.py:587:1: E101 indentation contains mixed spaces and tabs ./ipatests/test_xmlrpc/test_old_permission_plugin.py:587:80: E501 line too long (95 > 79 characters) ./ipatests/test_xmlrpc/test_old_permission_plugin.py:591:1: E101 indentation contains mixed spaces and tabs ./ipatests/test_xmlrpc/test_old_permission_plugin.py:591:1: W191 indentation contains tabs ./ipatests/test_xmlrpc/test_permission_plugin.py:821:80: E501 line too long (99 > 79 characters) ./ipatests/test_xmlrpc/test_permission_plugin.py:884:80: E501 line too long (99 > 79 characters) </body> </html>