<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<br>
<br>
<div class="moz-cite-prefix">On 25.02.2016 09:52, Milan Kubík wrote:<br>
</div>
<blockquote cite="mid:56CEC0C3.8040703@redhat.com" type="cite">
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<div class="moz-cite-prefix">On 02/24/2016 07:05 PM, Martin Basti
wrote:<br>
</div>
<blockquote cite="mid:56CDF0F5.2010506@redhat.com" type="cite">
<meta content="text/html; charset=utf-8"
http-equiv="Content-Type">
<br>
<br>
<div class="moz-cite-prefix">On 24.02.2016 08:34, Milan Kubík
wrote:<br>
</div>
<blockquote cite="mid:56CD5D22.9000404@redhat.com" type="cite">
<meta content="text/html; charset=utf-8"
http-equiv="Content-Type">
<div class="moz-cite-prefix">On 02/18/2016 03:52 PM, Milan
Kubík wrote:<br>
</div>
<blockquote cite="mid:56C5DA92.4090805@redhat.com" type="cite">
<meta content="text/html; charset=utf-8"
http-equiv="Content-Type">
<div class="moz-cite-prefix">On 02/15/2016 04:59 PM, Milan
Kubík wrote:<br>
</div>
<blockquote cite="mid:56C1F5C6.2090708@redhat.com"
type="cite">Patch attached. Applies on ipa-4-3 as well. <br>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
Updated version of patch fixes test_old_permission_plugin as
well.<br>
<br>
<pre class="moz-signature" cols="72">--
Milan Kubik</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
Review bump.<br>
<br>
<pre class="moz-signature" cols="72">--
Milan Kubik</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
NACK<br>
<br>
[mbasti@dhcp129-96 freeipa-devel]$ git show -U0 | pep8 --diff<br>
./ipatests/test_xmlrpc/test_old_permission_plugin.py:528:80:
E501 line too long (95 > 79 characters)<br>
./ipatests/test_xmlrpc/test_old_permission_plugin.py:586:1: E101
indentation contains mixed spaces and tabs<br>
./ipatests/test_xmlrpc/test_old_permission_plugin.py:586:1: W191
indentation contains tabs<br>
./ipatests/test_xmlrpc/test_old_permission_plugin.py:587:1: E101
indentation contains mixed spaces and tabs<br>
./ipatests/test_xmlrpc/test_old_permission_plugin.py:587:80:
E501 line too long (95 > 79 characters)<br>
./ipatests/test_xmlrpc/test_old_permission_plugin.py:591:1: E101
indentation contains mixed spaces and tabs<br>
./ipatests/test_xmlrpc/test_old_permission_plugin.py:591:1: W191
indentation contains tabs<br>
./ipatests/test_xmlrpc/test_permission_plugin.py:821:80: E501
line too long (99 > 79 characters)<br>
./ipatests/test_xmlrpc/test_permission_plugin.py:884:80: E501
line too long (99 > 79 characters)<br>
<br>
</blockquote>
Sorry for that. Updated patch attached.<br>
<br>
<pre class="moz-signature" cols="72">--
Milan Kubik</pre>
</blockquote>
ACK<br>
<br>
Pushed to:<br>
master: b32c9d639ef8e3fa852fb07f9385ae7e7b48e00e<br>
ipa-4-3: 5ae12641426427552406af89feb15e9bcbad8db3<br>
<br>
</body>
</html>