<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<br>
<br>
<div class="moz-cite-prefix">On 28.01.2016 17:32, Martin Babinsky
wrote:<br>
</div>
<blockquote cite="mid:56AA42AA.2010407@redhat.com" type="cite">On
01/28/2016 05:06 PM, Tomas Babej wrote:
<br>
<blockquote type="cite">
<br>
<br>
On 01/28/2016 04:44 PM, Martin Babinsky wrote:
<br>
<blockquote type="cite">On 01/28/2016 03:20 PM, Tomas Babej
wrote:
<br>
<blockquote type="cite">
<br>
<br>
On 01/27/2016 03:58 PM, Martin Babinsky wrote:
<br>
<blockquote type="cite">On 01/18/2016 06:43 PM, Martin
Babinsky wrote:
<br>
<blockquote type="cite">A little patch that should make
some future pylint errors disappear.
<br>
<br>
<br>
<br>
</blockquote>
Attaching updated patch that does not promote direct
molestation of
<br>
instance dictionaries.
<br>
<br>
<br>
<br>
</blockquote>
<br>
Patch looks good, one thing I am concerened about though is
that
<br>
__todict__ now returns a direct reference to the internal,
mutable dict,
<br>
and no longer a (shallow) copy.
<br>
<br>
Maybe we should use dict.copy() there?
<br>
<br>
Tomas
<br>
<br>
</blockquote>
<br>
Ah I didn't realize that. Fixed in updated patch.
<br>
<br>
</blockquote>
<br>
Nitpick: Sorry for being misleading - I did not mean to suggest
invoking
<br>
the method using the dict type directly. While being equivalent,
the
<br>
<br>
dict.copy(self.__options)
<br>
<br>
it's less idiomatic than:
<br>
<br>
self.__options.copy()
<br>
<br>
Tomas
<br>
<br>
</blockquote>
<br>
Ah sorry I forgot how to python again.
<br>
<br>
Attaching patch.
<br>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
Bump for review<br>
</body>
</html>