<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<br>
<br>
<div class="moz-cite-prefix">On 28.01.2016 10:45, Filip Skola wrote:<br>
</div>
<blockquote
cite="mid:212120579.19163053.1453974347696.JavaMail.zimbra@redhat.com"
type="cite">
<pre wrap="">
----- Original Message -----
</pre>
<blockquote type="cite">
<pre wrap="">On 01/18/2016 02:26 PM, Filip Skola wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Hi,
this should be fixed in this patch.
F.
----- Original Message -----
</pre>
<blockquote type="cite">
<pre wrap="">On 01/15/2016 03:37 PM, Filip Skola wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Hi,
sending rebased patch.
F.
----- Original Message -----
</pre>
<blockquote type="cite">
<pre wrap="">Hi,
the patch no longer applies to master. Please rebase it.
Thanks,
Milan
----- Original Message -----
From: "Filip Skola" <a class="moz-txt-link-rfc2396E" href="mailto:fskola@redhat.com"><fskola@redhat.com></a>
To: <a class="moz-txt-link-abbreviated" href="mailto:freeipa-devel@redhat.com">freeipa-devel@redhat.com</a>
Cc: "Milan Kubík" <a class="moz-txt-link-rfc2396E" href="mailto:mkubik@redhat.com"><mkubik@redhat.com></a>, "Aleš Mareček"
<a class="moz-txt-link-rfc2396E" href="mailto:amarecek@redhat.com"><amarecek@redhat.com></a>
Sent: Tuesday, 22 December, 2015 11:56:15 AM
Subject: [PATCH 0005] Refactor test_nesting, create HostGroupTracker
Hi,
another patch from refactoring-test_xmlrpc series.
Filip
</pre>
</blockquote>
</blockquote>
<pre wrap="">NACK, something seems to be missing in the patch
************* Module ipatests.test_xmlrpc.tracker.hostgroup_plugin
ipatests/test_xmlrpc/tracker/hostgroup_plugin.py:222: [E1101(no-member),
HostGroupTracker.check_add_member_negative] Instance of
'HostGroupTracker' has no 'adds' member)
--
Milan Kubik
</pre>
</blockquote>
</blockquote>
<pre wrap="">The same as with patch 0002:
************* Module ipatests.test_xmlrpc.tracker.hostgroup_plugin
W:142,26: Calling a dict.iter*() method (dict-iter-method)
Please use dict.items method.
--
Milan Kubik
</pre>
</blockquote>
<pre wrap="">
Hi,
attaching a fixed patch. This patch is dependent on updated group plugin test patch 0002-7.
Filip
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
Bump for review<br>
</body>
</html>