<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Fri, Mar 11, 2016 at 7:35 AM, Petr Vobornik <span dir="ltr"><<a href="mailto:pvoborni@redhat.com" target="_blank">pvoborni@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class=""><div class="h5">On 03/11/2016 03:00 PM, Rob Crittenden wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Martin Kosek wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
On 03/11/2016 09:55 AM, Jan Cholasta wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
On 11.3.2016 09:33, Martin Kosek wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
On 03/08/2016 07:07 PM, Martin Basti wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
<br>
On 08.03.2016 16:37, Martin Basti wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
<br>
On 08.03.2016 16:31, Martin Basti wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<a href="https://fedorahosted.org/freeipa/ticket/4501" rel="noreferrer" target="_blank">https://fedorahosted.org/freeipa/ticket/4501</a><br>
<br>
Patch attached.<br>
<br>
<br>
</blockquote>
Rebased patch attached.<br>
<br>
<br>
</blockquote>
<br>
self-NACK<br>
<br>
Scripts print to CLI unformatted strings, it should not be so easy.<br>
See /var/log/ipaupgrade-{timestamp}.log for more information<br>
</blockquote>
<br>
second-NACK. We cannot break existing log file paths. The paths are mentioned<br>
in a documentation and there may be also automation around that (gathering log<br>
files). So there should be always symlink from the well known location to the<br>
newest timestampe'd log.<br>
</blockquote>
<br>
Sorry, but this is absurd. What's the point of maintaining backward<br>
compatibility with obsolete documentation? Following this logic, we would not<br>
be able to change anything ever. What we should actually do is update the<br>
documentation. Ditto for automation.<br>
</blockquote>
<br>
+1 for updating the automation and documentation. But some backward<br>
compatibility will need to be retained, at least for the stable systems like<br>
RHEL where *other* people may have some automation or documentation around it,<br>
not just us.<br>
<br>
</blockquote>
<br>
Or you could just also create a symlink to the old name and it will<br>
always just work.<br>
<br>
rob<br>
<br>
</blockquote>
<br></div></div>
Aren't the symlinks what Martin2 mentioned in second-NACK?<br>
<br>
These new timestamped logs should be combined with the Gabe's patches: #5728 (renamed to command name) and #5724 (move to /var/log/ipa directory).<br>
<br>
So that there will be e.g.:<br>
/var/log/ipaserver-install.log -> /var/log/ipa-server-install-{timestamp}.log<br>
<br>
/var/log/ipa/ipa-server-install.log -> /var/log/ipa-server-install-{timestamp}.log<span class=""></span> <br></blockquote><div><br><div>I wonder if it would be simpler/better to always write to the *.log file, and then have old logs timestamped rather than write directly to a timestamped log file?<br></div><div>Then just symlink the original log file in /var/log/ to the new log file name/location in /var/log/ipa.<br><br></div><div>For example:<br>/var/log/ipaserver-install.log -> /var/log/ipa/ipa-server-install.log                <-- We write to this log (current)<br>                                            /var/log/ipa-server-install-{timestamp}.log   <-- Old log with some date<br>                                            /var/log/ipa-server-install-{timestamp}.log   <-- Older log with some date<br>                                            /var/log/ipa-server-install-{timestamp}.log   <-- Oldest log with some date<br><br></div><div><br></div>Gabe <br></div></div><br></div></div>