<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<br>
<br>
<div class="moz-cite-prefix">On 29.02.2016 16:02, David Kupka wrote:<br>
</div>
<blockquote
cite="mid:1542878923.39274119.1456758177069.JavaMail.zimbra@redhat.com"
type="cite">
<pre wrap="">Hello Christian,
sorry for letting this patch rot for so long. I've forget about it the minute Fraser replied.
To compensate a little I've fixed pep8 error, rebased it and attaching two versions for master and for 4.3 branch.
I haven't found any missing cases and it works for me. If you're OK with the modified patches it can be pushed.
David
----- Original Message -----
From: "Christian Heimes" <a class="moz-txt-link-rfc2396E" href="mailto:cheimes@redhat.com"><cheimes@redhat.com></a>
To: "Fraser Tweedale" <a class="moz-txt-link-rfc2396E" href="mailto:ftweedal@redhat.com"><ftweedal@redhat.com></a>
Cc: "freeipa-devel" <a class="moz-txt-link-rfc2396E" href="mailto:freeipa-devel@redhat.com"><freeipa-devel@redhat.com></a>
Sent: Wednesday, January 20, 2016 11:57:42 AM
Subject: Re: [Freeipa-devel] [PATCH 0029] Move user/group constants for PKI and DS into ipaplatform
On 2016-01-20 02:54, Fraser Tweedale wrote:
</pre>
<blockquote type="cite">
<pre wrap="">On Tue, Jan 19, 2016 at 02:20:27PM +0100, Christian Heimes wrote:
</pre>
<blockquote type="cite">
<pre wrap="">ipaplatform.constants has platform specific names for a couple of system
users like Apache HTTPD. The user names for PKI_USER, PKI_GROUP, DS_USER
and DS_GROUP are defined in other modules. Similar to #5587 the patch my
patch moves the constants into the platform module.
<a class="moz-txt-link-freetext" href="https://fedorahosted.org/freeipa/ticket/5619">https://fedorahosted.org/freeipa/ticket/5619</a>
</pre>
</blockquote>
<pre wrap="">
I see a few remaining cases:
ipaserver/install/dsinstance.py
712: pent = pwd.getpwnam("dirsrv")
ipatests/test_integration/test_backup_and_restore.py
167: self.master.run_command(['userdel', 'dirsrv'])
168: self.master.run_command(['userdel', 'pkiuser'])
ipaplatform/redhat/tasks.py
441: if name == 'pkiuser':
When these are included, ACK.
</pre>
</blockquote>
<pre wrap="">
Good catch!
My new patch takes care of remaining cases.
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
<br>
Christian do you agree with proposed changes, can we push it?<br>
Martin^2<br>
</body>
</html>