<html> <head> <meta content="text/html; charset=windows-1252" http-equiv="Content-Type"> </head> <body text="#000000" bgcolor="#FFFFFF"> <div class="moz-cite-prefix">On 21.03.2016 10:33, Christian Heimes wrote: </div> <blockquote cite="mid:56EFBFEA.4080103@redhat.com" type="cite"> <pre wrap="">On 2016-03-21 10:29, Petr Spacek wrote: </pre> <blockquote type="cite"> <pre wrap="">On 20.3.2016 21:56, Martin Basti wrote: </pre> <blockquote type="cite"> <pre wrap="">Patches attached. </pre> </blockquote> <pre wrap=""> I do not really like freeipa-mbasti-0442-pylint-remove-bare-except because it replaces most of try: ... except: with try: ... except Exception: which AFAIK does not add any value. It would be better to replace Exception with more specific exception so the code raises an error instead of continuing when something really unexpected happens. </pre> </blockquote> <pre wrap=""> It adds some value. A bare except also excepts signals like KeyboardInterrupt and SystemExit. except Exception doesn't block these exceptions. But yes, more specific exceptions are better. Christian </pre> <fieldset class="mimeAttachmentHeader"></fieldset> </blockquote> 'except Exception' is another pylint check :D I replaced bare except with a particular exception in cases where it was clear. For other occurrences of bare except it covers too much Exception types, so catch Exception is more sensible, or I need crystal ball to detect what kind of exceptions can be raised there. Martin^2 </body> </html>