<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Ping<br>
<br>
<div class="moz-cite-prefix">On 03/22/2016 04:32 PM, Abhijeet
Kasurde wrote:<br>
</div>
<blockquote cite="mid:56F12632.40903@redhat.com" type="cite">Hi All,
<br>
<br>
Please find the updated patches as per review comments.
<br>
<br>
On 03/18/2016 07:39 PM, Petr Vobornik wrote:
<br>
<blockquote type="cite">On 03/18/2016 02:21 PM, Abhijeet Kasurde
wrote:
<br>
<blockquote type="cite">Hi All,
<br>
<br>
Please review these patches.
<br>
<br>
Fixes : <a class="moz-txt-link-freetext" href="https://fedorahosted.org/freeipa/ticket/5077">https://fedorahosted.org/freeipa/ticket/5077</a>
<br>
<br>
Thanks,
<br>
Abhijeet Kasurde
<br>
<br>
</blockquote>
<br>
'invalid' is a default and right now is meant for invalid
password(not correct, see below). So by reading the patch, it
will break the case when user sets invalid password.
<br>
<br>
Better would be to process kinit output in
rpcserver.py:login_password and set e.g: 'krbprincipal-expired'
reason.
<br>
<br>
Then add it to a list of known errors in
ipa.js:login_password:498. We should probaly add also
'invalid-password' to the list.
<br>
<br>
Then do the change as in this patch but only with:
'krbprincipal-expired'.
<br>
<br>
If 'invalid-password' is added to the list of know errors then
we should change the default error from "The password or
username you entered is incorrect. " to e.g.: 'Login failed from
unknown reason"
<br>
<br>
</blockquote>
Thanks Petr for suggestions.
<br>
<br>
Thanks,
<br>
Abhijeet Kasurde
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
<br>
</body>
</html>