<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<br>
<br>
<div class="moz-cite-prefix">On 04/04/2016 06:54 PM, Martin Basti
wrote:<br>
</div>
<blockquote cite="mid:57029C43.7000309@redhat.com" type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
<br>
<br>
<div class="moz-cite-prefix">On 01.04.2016 14:34, Pavel Vomacka
wrote:<br>
</div>
<blockquote cite="mid:56FE6ACE.1050705@redhat.com" type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
<br>
<br>
<div class="moz-cite-prefix">On 03/31/2016 04:16 PM, Lenka
Doudova wrote:<br>
</div>
<blockquote cite="mid:56FD314C.4080809@redhat.com" type="cite">
<br>
<br>
On 03/31/2016 12:42 PM, Pavel Vomacka wrote: <br>
<blockquote type="cite"> <br>
<br>
On 03/18/2016 11:24 AM, Lenka Doudova wrote: <br>
<blockquote type="cite"> <br>
<br>
On 03/10/2016 06:58 PM, Petr Vobornik wrote: <br>
<blockquote type="cite">On 03/08/2016 01:17 PM, Lenka
Doudova wrote: <br>
<blockquote type="cite"> <br>
<br>
On 03/08/2016 12:59 PM, Petr Vobornik wrote: <br>
<blockquote type="cite">On 03/07/2016 04:29 PM, Pavel
Vomacka wrote: <br>
<blockquote type="cite"> <br>
<br>
On 02/25/2016 03:08 PM, Lenka Doudova wrote: <br>
<blockquote type="cite">Hi, <br>
<br>
here's a patch for webUI tests that provides
test for creating user <br>
without private group. <br>
Related to ticket <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="https://fedorahosted.org/freeipa/ticket/4986">https://fedorahosted.org/freeipa/ticket/4986</a>
<br>
<br>
Since the option to specify GID when creating a
user is not available <br>
<a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="https://fedorahosted.org/freeipa/ticket/5505">https://fedorahosted.org/freeipa/ticket/5505</a>
the test creates a new <br>
posix group, makes it a default user group
instead of 'ipausers' and <br>
then attemps to create the user without private
group. Returning <br>
default user group value to 'ipausers' is
provided even for cases when <br>
the test fails so it would not block other tests
from performing <br>
properly. <br>
<br>
Lenka <br>
<br>
<br>
</blockquote>
Hi, <br>
<br>
ACK, works well. <br>
<br>
Pavel^3 Vomacka <br>
<br>
</blockquote>
<br>
NACK, don't use naked except, specify at least
'Exception' <br>
+ except: <br>
<br>
</blockquote>
<br>
Thanks, patch fixed according to Petr's review
attached. <br>
<br>
Lenka <br>
</blockquote>
<br>
Ticket 5505 was pushed. So the workaround can be
removed. Do you prefer to do it in this patch? <br>
<br>
Also, maybe it would be good to test both cases and
check if the error is actually the right one. <br>
</blockquote>
<br>
Hi, <br>
<br>
attaching patch fixed according to recently pushed
changes. <br>
<br>
Lenka <br>
</blockquote>
Hi, <br>
<br>
NACK, <br>
<br>
1) The data definition for user3 (user.DATA3) is not used
anywhere. And the definition is actually the same as
definition of user4. So, I think that it could be removed. <br>
<br>
2) This is just a detail, but I would rather use
'combobox_input' or 'combobox_textbox' as parameter name
because the parameter actually doesn't represent the value
of combobox. <br>
<br>
Otherwise it works as expected. <br>
<br>
-- <br>
Pavel^3 Vomacka <br>
<br>
</blockquote>
Hi, <br>
<br>
thanks for comments, updated patch attached. <br>
<br>
Lenka <br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
Thank you, ACK. <br>
<br>
--<br>
Pavel^3 Vomacka<br>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
Ticket is in closed milestone, this patch cannot be attached to
closed milestone, please create a new ticket/or post the proper
ticket.<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
Hi,<br>
<br>
new ticket has been created for this issue. Patch with modified
commit message to refer to the new ticket attached.<br>
Lenka
</body>
</html>