<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<br>
<br>
<div class="moz-cite-prefix">On 14.04.2016 14:04, Oleg Fayans wrote:<br>
</div>
<blockquote cite="mid:570F8754.4080503@redhat.com" type="cite">
<pre wrap="">The new version disables a falsely failing pylint check for ldap_connect
method in a master host instance.
On 04/13/2016 10:30 AM, Oleg Fayans wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Hi Martin,
I've updated the patch with regard to your review. Thank you!
On 04/12/2016 03:35 PM, Martin Babinsky wrote:
</pre>
<blockquote type="cite">
<pre wrap="">On 04/07/2016 12:35 PM, Oleg Fayans wrote:
</pre>
<blockquote type="cite">
<pre wrap="">
</pre>
</blockquote>
<pre wrap="">Hi Oleg,
since this is a part of replica promotion test suite please add the link
to <a class="moz-txt-link-freetext" href="https://fedorahosted.org/freeipa/ticket/5723">https://fedorahosted.org/freeipa/ticket/5723</a> to the commit message.
</pre>
</blockquote>
<pre wrap="">
Done
</pre>
<blockquote type="cite">
<pre wrap="">
The patch cannot be applied cleanly, even 3-way merge fails with:
"""
git am
../review/ofayans/freeipa-ofayans-0035-Add-test-if-replica-is-working-after-domain-upgrade.patch
-3
Applying: Add test if replica is working after domain upgrade
error: invalid object 100644 acae5c924594cc73bf262eeab5f843f252723207
for 'ipatests/test_integration/test_replica_promotion.py'
fatal: git-write-tree: error building trees
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Add test if replica is working after domain upgrade
"""
I had to fall back to plain 'patch -p1'
I have your previous patches 0033-0034 applied. The patch probably needs
a rebase.
</pre>
</blockquote>
<pre wrap="">
Fixed
</pre>
<blockquote type="cite">
<pre wrap="">
Also I would be more happy if the username for 'testuser' was not
hardcoded in the code. You can factor it out as a class member.
</pre>
</blockquote>
<pre wrap="">
Done
</pre>
</blockquote>
<pre wrap="">
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
<br>
I suggest to put missing member here:<br>
<br>
diff --git a/pylint_plugins.py b/pylint_plugins.py<br>
index c3042f4..7a421ab 100644<br>
--- a/pylint_plugins.py<br>
+++ b/pylint_plugins.py<br>
@@ -230,6 +230,7 @@ ipa_class_members = {<br>
{'transport': ['put_file']},<br>
'put_file_contents',<br>
'get_file_contents',<br>
+ 'ldap_connect',<br>
]},<br>
'replicas',<br>
'clients',<br>
<br>
instead of disabling the check locally (untested)<br>
<br>
Martin^2<br>
</body>
</html>