<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
On 04/21/2016 11:19 AM, Martin Basti wrote:<br>
<blockquote cite="mid:57189B31.9090209@redhat.com" type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
<br>
<br>
<div class="moz-cite-prefix">On 20.04.2016 17:27, Martin Basti
wrote:<br>
</div>
<blockquote cite="mid:57179FD4.5070904@redhat.com" type="cite"> <br>
<br>
On 24.03.2016 14:27, Martin Basti wrote: <br>
<blockquote type="cite"> <br>
<br>
On 24.03.2016 13:55, Jan Cholasta wrote: <br>
<blockquote type="cite">On 18.3.2016 23:27, Timo Aaltonen
wrote: <br>
<blockquote type="cite">On 17.03.2016 18:36, Martin Basti
wrote: <br>
<blockquote type="cite"><a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="https://fedorahosted.org/freeipa/ticket/5681">https://fedorahosted.org/freeipa/ticket/5681</a>
<br>
</blockquote>
<br>
would be nicer if ipa-httpd.conf was a template with the
current <br>
hardcoded values replaced with platform paths.. <br>
</blockquote>
<br>
+1, I would also prefer if the file was renamed to
init/systemd/httpd.conf rather than
install/share/ipa-httpd.conf. <br>
</blockquote>
ipa-httpd.conf.template should be in /user/share/ipa,
directory init/systemd copied only to rpm and then copied to
/etc/systemd/system AFAIK <br>
<br>
<blockquote type="cite"> <br>
<blockquote type="cite"> <br>
<br>
not relevant to this patch, but there are others
candidates for <br>
templates like: <br>
<br>
daemons/dnssec/ipa-dnskeysyncd.service <br>
daemons/dnssec/ipa-ods-exporter.service <br>
install/conf/ipa.conf <br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
Updated patch attached, sorry for delay. <br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
Updated patch attached (fixed unused import).<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
<br>
Seems to work as expected. However, wouldn't it be better to use
installutils.remove_file instead of remove_httpd_service_ipa_conf
(or at least log the possible error during os.unlink) to get the
same behavior as with the other config files?
</body>
</html>