<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<br>
<br>
<div class="moz-cite-prefix">On 22.04.2016 15:38, Stanislav Laznicka
wrote:<br>
</div>
<blockquote cite="mid:571A2947.4040604@redhat.com" type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
Seems to work as expected.<br>
<br>
Nitpick: feel free to fix the typo in the commit message:
behavioar. ACK nonetheless.<br>
</blockquote>
Standa forgot to sent ACK on list :), please note that ACK is here
-----^^^^<br>
Typo fixed<br>
<br>
Pushed to master: 14ee02dcbd6cbb6c221ac7526e471a9fc58fcc82<br>
<br>
Martin^2<br>
<br>
<blockquote cite="mid:571A2947.4040604@redhat.com" type="cite"> <br>
<br>
<div class="moz-cite-prefix">On 04/14/2016 05:16 PM, Martin Basti
wrote:<br>
</div>
<blockquote cite="mid:570FB451.60409@redhat.com" type="cite"> <br>
<br>
On 21.03.2016 07:48, Jan Cholasta wrote: <br>
<blockquote type="cite">On 18.3.2016 13:24, Martin Babinsky
wrote: <br>
<blockquote type="cite">On 03/15/2016 01:48 PM, Martin Basti
wrote: <br>
<blockquote type="cite"><a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="https://fedorahosted.org/freeipa/ticket/3376">https://fedorahosted.org/freeipa/ticket/3376</a>
<br>
<br>
Patch attached. <br>
<br>
<br>
</blockquote>
ACK but fix the 'behavioar' typo in the commit message
before pushing. <br>
</blockquote>
<br>
1) You are breaking the default_attributes contract by
declaring ipasshpubkey as default attribute and then removing
it from the result. This is a hack, which makes the code less
readable ("If ipasshpubkey is in default_attributes, why am I
not getting it in the result?") and requires every developer
to remember to remove ipasshpubkey themselves if they are
using user/host objects in their code and want the same
behavior as user/host commands. Please keep the change
isolated in the relevant commands. <br>
<br>
2) Don't add ipasshpubkey to search_attributes, we don't want
user-find and friends to search inside ipasshpubkey. <br>
<br>
</blockquote>
Updated patch attached. <br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>