[Freeipa-users] Building previous release rpms are failing

[Martin Kosek]

On 08/05/2014 12:05 PM, Curtis L. Knight wrote:
> Hey,
> 
> I have been trying to build rpms from different releases without much
> success. I can build 4.0+ rpms but I have not tested them. Going backward
> like with release-3-3-5, it fails on lint/pylint routine. I comment out the
> lint call in the Makefile and further along it cannot find some ui files.

You could also run

$ make rpms DEVELOPER_MODE=1

to have the lint run, but ignored it's results (though fixing the bug it is
better of course).

> 
> I got this setup to use docker to generate the rpms. Included below are the
> sequences and commands.
> 
> for current release that does build without intervention:
> # docker run -ti --name freeipa-devel-rpms-container
> knighcl/freeipa-devel-rpms:fedora-20 release-4-0-1
> 
> or for master
> 
> # docker run -ti --name freeipa-devel-rpms-container
> knighcl/freeipa-devel-rpms:fedora-20
> 
> for previous release
> # docker run -ti --name freeipa-devel-rpms-container
> knighcl/freeipa-devel-rpms:fedora-20 release-3-3-5
> 
> Once dropped into the terminal upon finishing, I edit the Makefile to
> comment out the make-lint line within the lint stanza
> 
> #./make-lint $(LINT_OPTIONS)
> 
> run 'make rpms' again to get beyond lint errors shown below
> 
> 
> cd install; if [ ! -e Makefile ]; then ../autogen.sh --prefix=/usr
> --sysconfdir=/etc --localstatedir=/var --libdir=/usr/lib; fi
> ./make-lint
> Traceback (most recent call last):
>   File "./make-lint", line 272, in <module>
>     sys.exit(main())
>   File "./make-lint", line 243, in main
>     linter.check(files)
>   File "/usr/lib/python2.7/site-packages/pylint/lint.py", line 626, in check
>     self.check_astroid_module(astroid, walker, rawcheckers, tokencheckers)
>   File "/usr/lib/python2.7/site-packages/pylint/lint.py", line 712, in
> check_astroid_module
>     walker.walk(astroid)
>   File "/usr/lib/python2.7/site-packages/pylint/utils.py", line 715, in walk
>     self.walk(child)
>   File "/usr/lib/python2.7/site-packages/pylint/utils.py", line 715, in walk
>     self.walk(child)
>   File "/usr/lib/python2.7/site-packages/pylint/utils.py", line 712, in walk
>     cb(astroid)
>   File "/usr/lib/python2.7/site-packages/pylint/checkers/newstyle.py",
> line 135, in visit_function
>     args=(call.args[0].name, ))
> AttributeError: 'Getattr' object has no attribute 'name'
> make: *** [lint] Error 1

This is new, I created upstream ticket to timely fix it:
https://fedorahosted.org/freeipa/ticket/4475

> The final errors from the build are below. I tried to find the jdennis
> building/ci script to see if there is something I am missing but I am
> guessing it is on the build system. This was an exercise on building rpms
> and learning docker to possibly help the developers out with a new process.
> I do not need to do this successfully but thought you might want to know
> that something might not be proper.
> 
> Regards,
> Curtis
> 
> rpm 3.3.5 log
>  /usr/bin/mkdir -p
> '/freeipa/rpmbuild/BUILDROOT/freeipa-3.3.5GITd366595-0.fc20.x86_64/usr/share/ipa/ui/js/dojo'
>  /usr/bin/install -c -m 644 -p dojo.js
> '/freeipa/rpmbuild/BUILDROOT/freeipa-3.3.5GITd366595-0.fc20.x86_64/usr/share/ipa/ui/js/dojo'
> make[6]: Leaving directory
> `/freeipa/rpmbuild/BUILD/freeipa-3.3.5GITd366595/install/ui/build/dojo'
> make[5]: Leaving directory
> `/freeipa/rpmbuild/BUILD/freeipa-3.3.5GITd366595/install/ui/build/dojo'
> Making install in freeipa
> make[5]: Entering directory
> `/freeipa/rpmbuild/BUILD/freeipa-3.3.5GITd366595/install/ui/build/freeipa'
> ../../util/make-ui.sh
> Error: Could not find or load main class
> org.mozilla.javascript.tools.shell.Main
> Error: Could not find or load main class
> org.mozilla.javascript.tools.shell.Main
> Error: Could not find or load main class
> org.mozilla.javascript.tools.shell.Main
> /freeipa/rpmbuild/BUILD/freeipa-3.3.5GITd366595/install/ui/util/compile.sh:
> line 114: pushd:
> /freeipa/rpmbuild/BUILD/freeipa-3.3.5GITd366595/install/ui/util/../release/lib/freeipa:
> No such file or directory
> Invalid build dir:
> /freeipa/rpmbuild/BUILD/freeipa-3.3.5GITd366595/install/ui/util/../release/lib/freeipa
> make[6]: Entering directory
> `/freeipa/rpmbuild/BUILD/freeipa-3.3.5GITd366595/install/ui/build/freeipa'
> make[6]: Nothing to be done for `install-exec-am'.
> ../../util/make-ui.sh
> Error: Could not find or load main class
> org.mozilla.javascript.tools.shell.Main
> Error: Could not find or load main class
> org.mozilla.javascript.tools.shell.Main
> Error: Could not find or load main class
> org.mozilla.javascript.tools.shell.Main
> /freeipa/rpmbuild/BUILD/freeipa-3.3.5GITd366595/install/ui/util/compile.sh:
> line 114: pushd:
> /freeipa/rpmbuild/BUILD/freeipa-3.3.5GITd366595/install/ui/util/../release/lib/freeipa:
> No such file or directory
> Invalid build dir:
> /freeipa/rpmbuild/BUILD/freeipa-3.3.5GITd366595/install/ui/util/../release/lib/freeipa
>  /usr/bin/mkdir -p
> '/freeipa/rpmbuild/BUILDROOT/freeipa-3.3.5GITd366595-0.fc20.x86_64/usr/share/ipa/ui/js/freeipa'
>  /usr/bin/install -c -m 644 -p ./app.js
> '/freeipa/rpmbuild/BUILDROOT/freeipa-3.3.5GITd366595-0.fc20.x86_64/usr/share/ipa/ui/js/freeipa'
> /usr/bin/install: cannot stat './app.js': No such file or directory
> make[6]: *** [install-appDATA] Error 1
> make[6]: Leaving directory
> `/freeipa/rpmbuild/BUILD/freeipa-3.3.5GITd366595/install/ui/build/freeipa'
> make[5]: *** [install-am] Error 2
> make[5]: Leaving directory
> `/freeipa/rpmbuild/BUILD/freeipa-3.3.5GITd366595/install/ui/build/freeipa'
> make[4]: *** [install-recursive] Error 1
> make[4]: Leaving directory
> `/freeipa/rpmbuild/BUILD/freeipa-3.3.5GITd366595/install/ui/build'
> make[3]: *** [install-recursive] Error 1
> make[3]: Leaving directory
> `/freeipa/rpmbuild/BUILD/freeipa-3.3.5GITd366595/install/ui'
> make[2]: *** [install-recursive] Error 1
> make[2]: Leaving directory
> `/freeipa/rpmbuild/BUILD/freeipa-3.3.5GITd366595/install'
> make[1]: *** [install] Error 1
> make[1]: Leaving directory `/freeipa/rpmbuild/BUILD/freeipa-3.3.5GITd366595'
> error: Bad exit status from /var/tmp/rpm-tmp.4ZvCpe (%install)
> 
> 
> RPM build errors:
>     Bad exit status from /var/tmp/rpm-tmp.4ZvCpe (%install)
> make: *** [rpms] Error 1

This is caused by missing build dependency on rhino. I cherry-picked the patch
fixing this error and pushed to ipa-3-3 branch. With that patch available +
DEVELOPER_MODE workaround, you should be able to have your build running.

HTH,
Martin