[Freeipa-users] IE10 Dialogs close on Enter keypress

Petr Vobornik pvoborni at redhat.com
Wed Jan 20 17:52:47 UTC 2016


On 01/07/2016 06:11 AM, Jim Groffen wrote:
> Hello,
>
> I found that when running FreeIPA Web UI on IE10 that modal dialogs close
> when enter is pressed. Normal functionality is to 'submit' the dialog on an
> enter keypress.
>
> I found a solution by adding a type="button" attribute to the close button
> of the dialog (in /install/ui/src/freeipa/dialog.js).
>
> I have tested on recent Chrome, IE and Firefox versions as well as on IE10.
> Seems to be no side-effects.
>
> Attached is a patch showing the change I made. Apologies if the patch isn't
> formatted correctly.
>
> Regards,
>
> Jim G
>

Thanks for the patch. Looks good - ACK

was pushed to master branch

https://fedorahosted.org/freeipa/changeset/f5f5c8c603e95d246d2cde92f56959fedba4666d
-- 
Petr Vobornik




More information about the Freeipa-users mailing list