Draft patch for mtime, symlink attribute and symlink path

[Atul Aggarwal]

Hi,

boost::filesystem::path sym_pth (symlink_path);
>
>  that line is not used, you should remove it.



I could not find this line in the patch. Am i missing something?


>
>
> case 'l': e.symlink_attribute = true; break;
>

>  these lines should be changed to:
>
> case 'l': e.symlink_attribute = true; e.size = 0; break;


Done.

>
> fs::path symlink_pth ("");
>
>  you don't actually have to explicitly construct the path, you can just
> pass ""
> directly to the function.


This seemed interesting, hence i removed the another declaration of add_file
and pass the default value of "" to symlink_path in the existing function.

>
> Also, could you make a patch against the current trunk?


Done.

Any other changes todo?
-- 
Regards
Atul Aggarwal
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/instantmirror-list/attachments/20090625/4c2d92ce/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: symlink.diff
Type: application/octet-stream
Size: 11153 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/instantmirror-list/attachments/20090625/4c2d92ce/attachment.obj>