LTSP-SERVER-INITIALIZE script fixed !!!!!!
Warren Togami
wtogami at redhat.com
Mon Jul 14 20:04:48 UTC 2008
nilakhya chatterjee wrote:
> please test the following scripts as the modifications for the
> ltsp-server-initialise script and its helper script dhcpd-update
>
> place the ltsp-server-initialise script in your /usr/sbin directory
>
>
> place the dhcpd-update script in your /usr/share/ltsp/scripts directory
>
>
> and use the command ltsp-server-initialise -y
>
>
Thanks for looking at it. Here are some comments...
1) Could you please submit proposed changes as unified diff format
patches? bzr diff does unidiff by default. Otherwise diff -u will do it.
2) I don't understand the purpose of dhcpd-update. Can anybody explain?
And is this really safe?
> @@ -39,8 +52,8 @@
> while ($nm[$i] == "255") {
> if ($net) {
> $net = $net . ".";
> - $orignet = $orignet . ".";
> - }
> + $orignet = $orignet . ".";
> + }
> $net = $net . $nw[$i];
> $orignet = $orignet . $orignw[$i];
> ++$i;
>
3) Why this change?
Warren
More information about the K12Linux-devel-list
mailing list