[katello-devel] Fwd: [katello-commits] [katello] adding new parameter --nodisc for product creation

Lukas Zapletal lzap at redhat.com
Tue Nov 1 10:12:31 UTC 2011


Ola!

I have decided to clean up my TODO list and pushed various small 
improvements. One of these is new parameter --nodisc which disables 
auto-discovery for repos. Kinda slow.

# katello product create --provider muni --name f15 --url 
http://ftp.linux.cz/pub/linux/fedora/linux/releases/15/Fedora/x86_64/ 
--nodisc

I also have fixed an annoying bug when Katello was making too many 
requests to Pulp when async job was running. Now we do two requests per 
seconds max, everything seems to be smoother now.

Ok, back to bug-squashing.

LZ

-------- Original Message --------
Subject: [katello-commits] [katello] adding new parameter --nodisc for 
product creation
Date: Tue,  1 Nov 2011 10:03:26 +0000 (UTC)
From: lzap <lzap at fedoraproject.org>
Reply-To: katello-commits at lists.fedorahosted.org
To: katello-commits at lists.fedorahosted.org

commit 95c0e46a2963cbfa2c020d494c9456d601fb77c6
Author: Lukas Zapletal <lzap+git at redhat.com>
Date:   Tue Nov 1 10:18:49 2011 +0100

     adding new parameter --nodisc for product creation

     It just skips autodiscovery for repos.

  cli/src/katello/client/core/product.py |   16 ++++++++++------
  1 files changed, 10 insertions(+), 6 deletions(-)
---
diff --git a/cli/src/katello/client/core/product.py 
b/cli/src/katello/client/core/product.py
index 61ed996..0aad7f2 100644
--- a/cli/src/katello/client/core/product.py
+++ b/cli/src/katello/client/core/product.py
@@ -249,6 +249,8 @@ class Create(ProductAction):
                                 help=_("product description"))
          self.parser.add_option("--url", dest="url",
                                 help=_("repository url eg: 
http://download.fedoraproject.org/pub/fedora/linux/releases/"))
+        self.parser.add_option("--nodisc", action="store_true", 
dest="nodiscovery",
+                               help=_("skip repository discovery"))
          self.parser.add_option("--assumeyes", action="store_true", 
dest="assumeyes",
                                 help=_("assume yes; automatically 
create candidate repositories for discovered urls (optional)"))

@@ -265,11 +267,12 @@ class Create(ProductAction):
          description = self.get_option('description')
          url         = self.get_option('url')
          assumeyes   = self.get_option('assumeyes')
+        nodiscovery = self.get_option('nodiscovery')

-        return self.create_product_with_repos(provName, orgName, name, 
description, url, assumeyes)
+        return self.create_product_with_repos(provName, orgName, name, 
description, url, assumeyes, nodiscovery)


-    def create_product_with_repos(self, provName, orgName, name, 
description, url, assumeyes):
+    def create_product_with_repos(self, provName, orgName, name, 
description, url, assumeyes, nodiscovery):
          prov = get_provider(orgName, provName)
          if prov == None:
              return os.EX_DATAERR
@@ -280,10 +283,11 @@ class Create(ProductAction):
          if url == None:
              return os.EX_OK

-        repourls = self.discoverRepos.discover_repositories(orgName, url)
-        self.printer.setHeader(_("Repository Urls discovered @ [%s]" % 
url))
-        selectedurls = self.discoverRepos.select_repositories(repourls, 
assumeyes)
-        self.discoverRepos.create_repositories(prod["id"], 
prod["name"], selectedurls)
+        if not nodiscovery:
+            repourls = 
self.discoverRepos.discover_repositories(orgName, url)
+            self.printer.setHeader(_("Repository Urls discovered @ 
[%s]" % url))
+            selectedurls = 
self.discoverRepos.select_repositories(repourls, assumeyes)
+            self.discoverRepos.create_repositories(prod["id"], 
prod["name"], selectedurls)

          return os.EX_OK

_______________________________________________
katello-commits mailing list
katello-commits at lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/katello-commits




More information about the katello-devel mailing list