[katello-devel] PATCH: katello-configure: If unexpected error is seen, report it as well.

[Jan Pazdziora]

On Wed, Nov 02, 2011 at 03:47:33PM +0100, Jan Pazdziora wrote:
> 
> please consider for review patch which adds nonzero exit status if
> error was seen in katello-configure during puppet execution.

On top of the previous patch, please also consider patch which will
cause katello-configure to show the pinkish puppet error lines, and
consider them as errors.


>From cb140ed493b375a259053ecf075df5f968a87aaf Mon Sep 17 00:00:00 2001
From: Jan Pazdziora <jpazdziora at redhat.com>
Date: Wed, 2 Nov 2011 15:46:06 +0100
Subject: [PATCH 2/2] If unexpected error is seen, report it as well.

---
 puppet/bin/katello-configure |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/puppet/bin/katello-configure b/puppet/bin/katello-configure
index 4c911cf..b6f76ac 100644
--- a/puppet/bin/katello-configure
+++ b/puppet/bin/katello-configure
@@ -252,6 +252,9 @@ begin
 					processing_logfile = nil
 					seen_err = true
 				end
+			elsif line =~ /err:/
+				print line
+				seen_err = true
 			end
 			if line =~ /\]: Executing \'(.+)/
 				line_rest = $1
-- 
1.7.4.4

-- 
Jan Pazdziora
Principal Software Engineer, Satellite Engineering, Red Hat