[katello-devel] Merged sync-improve branch to master

[Partha Aji]

----- Original Message -----
> From: "Tomas Strachota" <tstrachota at redhat.com>
> To: "Partha Aji" <paji at redhat.com>
> Cc: katello-devel at redhat.com
> Sent: Monday, November 21, 2011 2:01:10 PM
> Subject: Re: [katello-devel] Merged sync-improve branch to master
> 
> On 15/11/11 20:58, Partha Aji wrote:
> > Folks,
> > Merged the sync-improve branch to master like 5 minutes ago. With
> > this merge one should be able to
> > 1) See improved performance + ui enhancements to the Sync status
> > page. (We get repo information in bulk to speed up performance).
> > This will be even better once pulp provides us a way to get repo
> > sync status information in bulk.
> > 2) Enable/Disable (aka blacklist) repos imported from a manifest in
> > the redhat provider page.
> >
> > You would need to rake db:migrate to get up to date with this
> > merge. Shouldn't need to reset/wipe everything.
> >
> > Partha
> >
> 
> Hi,
> since we need to mirror the repo blacklisting to our CLI I have 3
> questions/notes/proposals:
> 
> 1) I should not be able to disable a repo once it's been promoted,
> right?
> BTW I saw that we check the 'promoted?' status only at view level
> where
> it disables the checkbox. There should be a constraint also in the
> controller.
> 
Its also on the model level. I mean when repository.save! happens
there is a RepoDisablementValidator who looks for promoted or not. 

> 2) We should add an option for listing all (disabled and enabled)
> repositories into the api.
> 
product.repos call has a include_disabled flag that will include both.
Do you want an API call that only gives disabled ? 
Feel free to tweak in repos.rb:)

> 3) A product is not displayed until it has at least one repo enabled.
> I
> think this is confusing from the CLI/API point of view. We should
> display all products otherwise a user cannot list repositories by a
> product and decide what to enable. Maybe same option list-disabled as
> in
> 2) would be a way to go.

Agreed on this . I missed this part. We can tweak the repositories controller
I guess to include the disabled ones all we need to do is repos(env, true) :)

> 
> 
> Opinions?
> 
> Thanks,
> Tomas
> 
> 
>