[katello-devel] Direct Pushes to Katello Master

[Mike McCune]

On 08/17/2012 08:32 AM, Tom McKay wrote:
>
>
> ----- Original Message -----
>> From: "Miroslav Suchý"<msuchy at redhat.com>
>> To: "katello-devel"<katello-devel at redhat.com>
>> Sent: Friday, August 17, 2012 10:06:58 AM
>> Subject: Re: [katello-devel] Direct Pushes to Katello Master
>>
>> On 08/17/2012 03:35 PM, Eric Helms wrote:
>>> I have seen what appears to be direct pushes to Katello master in
>>> the past week or two which goes against our core requirement that
>>> EVERYTHING going to master (minus tags) goes through via a Pull
>>> Request.  If this policy needs to be amended, then let's amend it
>>> instead of going around it or, better yet, if there are things
>>> that need to be direct pushed to a repository then perhaps that
>>> code needs to be in it's own repository so it can have it's own
>>> set of rules.
>>
>> Which *code* went directly?
>>
>> I'm pushing some commits directly, but they are rel-eng related. It
>> is
>> either tagged packages or changes in comps files.
>
> It is very important that the entire team(s) see the changes going into katello master. The best way to retain visibility is via pull-request for everything. Specifically, "rel-eng" changes will impact SAM/headpin too and our team needs to be aware of them.
>
> Unless there is an exceedingly good reason I am in favor of _all_ changes going through the pull-request process.


we agreed a while back that tito initiated changes (tags and specfile 
version diffs) should not require pull requests.

examples:

https://github.com/Katello/katello/commit/4e1bba08dd990273812ecb1d640179649642517d
https://github.com/Katello/katello/commit/ba4b853a4f5d5fb2fc1ebb5222f39617977b1452
https://github.com/Katello/katello/commit/d310f961d6e64e8ef96938fc09399b1a59fd104b


For any other changes to the structural nature of the specfile we should 
be using Pull Requests.

For actual code changes, we should always be using Pull Requests


Mike
-- 
Mike McCune
mmccune AT redhat.com
Red Hat Engineering       | Portland, OR
Systems Management        | 650.254.4248