[katello-devel] Demotions and deletions

[Justin Sherrill]

On 08/28/2012 12:13 PM, Mike McCune wrote:
> On 08/28/2012 06:22 AM, Jason Rist wrote:
>> On 08/28/2012 06:56 AM, Brad Buckingham wrote:
>>> On 08/28/2012 08:10 AM, Miroslav Suchý wrote:
>>>> On 08/28/2012 12:29 PM, Lukas Zapletal wrote:
>>>>> Hey,
>>>>>
>>>>> stumbled upon a bug 
>>>>> (https://bugzilla.redhat.com/show_bug.cgi?id=835875)
>>>>> that prevents you from creating a repository with a same name that 
>>>>> has
>>>>> been deleted (but promoted).
>>>>>
>>>>> Now the question - we now do support demotions (those promotions
>>>>> opposite - not sure about wording). Therefore I guess the proper
>>>>> solution would be to check if the repository (*) was already 
>>>>> promoted.
>>>>> If so, Katello will refuse to delete the object asking user to do the
>>>>> demotion.
>>>>>
>>>>> Opinions?
>>>>
>>>> +1
>>>> I was thinking for a while about offering to do demotion for them
>>>> (with big exclamation mark). But if that would be easy, you can easily
>>>> destroy your set up. So I would leave it to admin to do that by hand.
>>>>
>>>> -- 
>>>> Miroslav Suchy
>>>> Red Hat Systems Management Engineering
>>>>
>>>> _______________________________________________
>>>> katello-devel mailing list
>>>> katello-devel at redhat.com
>>>> https://www.redhat.com/mailman/listinfo/katello-devel
>>> Hi,
>>>
>>> The feature that was recently introduced in Katello is content
>>> deletion.  It allows for deletion of content (which includes things 
>>> such
>>> as products, repos, packages, errata, distributions and system
>>> templates) from any environment along the promotion path, except for 
>>> the
>>> Library.  It isn't really a demotion of content since it is possible to
>>> delete content from the an environment that is in the middle of the 
>>> path
>>> (e.g. assuming Library->Dev->Test, user could delete a package from Dev
>>> leaving it in Test).   For content deletion, all deletions are done via
>>> the Content->Changesets page in the UI.
>>>
>>> For reference, the following is a brief wiki on the feature:
>>> https://fedorahosted.org/katello/wiki/ContentDeletionDesign .
>>>
>>> In the bug mentioned, the issue is with deleting content via Content ->
>>> Repositories ->  Custom Content Repositories.  This deletes the
>>> repository from the Library; however, it appears to be leaving some 
>>> data
>>> in the later environments along the path.
>>>
>>> For this one, a couple of solutions might be:
>>> 1. Do not allow user to delete a repository.  (Doesn't sound good).
>>> 2. Allow the user to delete a repository, deleting it from the Library
>>> and all environments that it has been promoted to.  Prior to deletion,
>>> in the Deletion Confirmation dialog provide them with additional
>>> information  detailing all environments that the Repository will be
>>> deleted from.  For example,
>>>      Are you sure you want to delete repo ABC?
>>>      Warning! This repo currently exists in: Library->Dev->Test and
>>> Library->Dev2
>>>
>>> thanks,
>>> Brad
>>>
>>> _______________________________________________
>>> katello-devel mailing list
>>> katello-devel at redhat.com
>>> https://www.redhat.com/mailman/listinfo/katello-devel
>>
>> I like 2
>>
>> Will this also delete the data from the disk?
>>
>
> this violates our rule that:
>
> *** "All changes to content in any live environment must be through a 
> changeset" ***

So I sorta disagree with this, just because i can think of 4 examples 
where this isn't the case:

Deleting a product
Deleting a provider
Deleting an environment
Deleting an organization

At some point there are higher level concepts that modify the content in 
a  live environment that isn't through a changeset.  We just have to 
figure out where that line is :)   To me deleting a 'repo' is similar to 
deleting a product and provider in that it is deleting a high level 
concept that is 'above' environments.   If deleting a repo shouldn't 
delete across environments then the same should be for product and 
provider IMHO.

-Justin

>
> as well as our current setup that changesets only effect one environment.
>
> I'll keep repeating that over and over whenever anyone suggests a 
> feature that bypasses this rule or we decide we don't like this rule 
> anymore.  I'm hesitant to add any option that changes this core 
> behavior of Katello without serious consideration.
>
> What about option 3:
>
> 3) Allow user to delete custom repositories in the Library and then 
> message them that in order to re-create any repositories with the same 
> name they will need to go through and execute changesets in each of 
> their environments to delete the repos from anywhere they promoted to.
>
> We could auto create deletion changesets for them so all the changes 
> to the live environments would be tracked and done through our 
> existing mechanism.  If people really want it we can allow the "apply" 
> to mass-execute the changesets in order.  We would be maintaining our 
> existing rule above but allowing for an easier mechanism to mass 
> delete repositories
>
>
> Mike