[katello-devel] Commit Messages
jesus rodriguez
jesusr at redhat.com
Wed May 15 19:35:41 UTC 2013
On 05/15/2013 08:14 AM, Miroslav Suchý wrote:
> On 05/15/2013 10:58 AM, Petr Chalupa wrote:
>> We should have a test in CI to test that commit-messages are ok.
>
> I would be against strict and automated checking. I can give you dozens
> examples from past where the commit cannot be shortened to 50 or even 80
> characters without loosing the meaning.
>
+1 no automated checking. Honestly guidelines and public shaming
should be enough. If during a pull request the commit message doesn't
match the guidelines NACK it.
jesus
--
jesus m. rodriguez | jesusr at redhat.com
principal software engineer | irc: zeus
red hat systems management | 919.754.4413 (w)
rhce # 805008586930012 | 919.623.0080 (c)
+---------------------------------------------+
| "Those who cannot remember the past |
| are condemned to repeat it." |
| -- George Santayana |
+---------------------------------------------+
More information about the katello-devel
mailing list